Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Implement improvements to AWS Lambda metrics view #143113

Merged
merged 44 commits into from
Oct 25, 2022
Merged

[APM] Implement improvements to AWS Lambda metrics view #143113

merged 44 commits into from
Oct 25, 2022

Conversation

cauemarcondes
Copy link
Contributor

@cauemarcondes cauemarcondes commented Oct 11, 2022 •
edited
Loading

closes #142328

aws.lambda.metrics.mov

@cauemarcondes cauemarcondes force-pushed the apm-aws-lambda-v2-part2 branch from cc9dfc6 to 2c539d0 Compare October 11, 2022 20:11
@cauemarcondes cauemarcondes marked this pull request as ready for review October 13, 2022 19:59
@cauemarcondes cauemarcondes requested a review from a team as a code owner October 13, 2022 19:59
@botelastic botelastic bot added the Team:APM - DEPRECATED Use Team:obs-ux-infra_services. label Oct 14, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

@cauemarcondes cauemarcondes requested a review from a team October 18, 2022 17:21
sorenlouv
sorenlouv approved these changes Oct 24, 2022
View reviewed changes
Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@cauemarcondes cauemarcondes enabled auto-merge (squash) October 25, 2022 17:33
@cauemarcondes cauemarcondes merged commit aa97bff into elastic:main Oct 25, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
apm 1323 1331 +8

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.1MB 3.1MB +10.9KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
apm 53 56 +3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Oct 25, 2022
@cauemarcondes cauemarcondes deleted the apm-aws-lambda-v2-part2 branch October 25, 2022 18:50
@gbamparop gbamparop mentioned this pull request Apr 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorenlouv sorenlouv sorenlouv approved these changes

@dgieselaar dgieselaar dgieselaar left review comments

@gbamparop gbamparop gbamparop left review comments

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:enhancement Team:APM - DEPRECATED Use Team:obs-ux-infra_services. v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] Implement improvements to AWS Lambda metrics view
7 participants
@cauemarcondes @elasticmachine @kibana-ci @sorenlouv @dgieselaar @gbamparop @kibanamachine