-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RAM] Bug ordering log KPI #142940
[RAM] Bug ordering log KPI #142940
Conversation
Pinging @elastic/response-ops (Team:ResponseOps) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I'll test it a bit more next week but the code looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UI text LGTM, thanks!
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
* add ordering + bigger bucket for the KPI * css cleanup (cherry picked from commit 2efcf7a)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
Summary
Fix: #142910
To resolve this problem, we are thinking about doing two thing:
We kind of worry about the memory when we changed the bucket to 10000. So we did some stats by using
Buffer.byteLength(JSON.stringify(results));
. The results below:Bucket of 10000, we do have 5.9 Mb in memory of the node
Bucket of 5000, we do have 2.9Mb in memory of the node
Bucket of 1000, we do have 590 kb in memory of the node
Reviewer what do you think?
Checklist