Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RAM] Bug ordering log KPI #142940

Merged
merged 6 commits into from
Oct 11, 2022
Merged

[RAM] Bug ordering log KPI #142940

merged 6 commits into from
Oct 11, 2022

Conversation

XavierM
Copy link
Contributor

@XavierM XavierM commented Oct 7, 2022

Summary

Fix: #142910

To resolve this problem, we are thinking about doing two thing:

  • Make sure we get our latest run to build the KPI
  • Move up the bucket size on the KPI query

We kind of worry about the memory when we changed the bucket to 10000. So we did some stats by using Buffer.byteLength(JSON.stringify(results));. The results below:
Bucket of 10000, we do have 5.9 Mb in memory of the node
Bucket of 5000, we do have 2.9Mb in memory of the node
Bucket of 1000, we do have 590 kb in memory of the node

Reviewer what do you think?

Checklist

@XavierM XavierM added bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.5.0 ci:cloud-deploy Create or update a Cloud deployment v8.6.0 labels Oct 7, 2022
@XavierM XavierM requested a review from a team as a code owner October 7, 2022 14:46
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@EricDavisX
Copy link
Contributor

tested via the cloud build and this looks ok to me. i'm going to let the env sit for a while and check it again, when it's rule counts have gotten up to 10k+ runs

for now, screenshot from test cloud cluster:
Screen Shot 2022-10-07 at 2 43 19 PM

Copy link
Contributor

@JiaweiWu JiaweiWu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'll test it a bit more next week but the code looks good

@XavierM XavierM enabled auto-merge (squash) October 11, 2022 19:26
Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI text LGTM, thanks!

@lcawl lcawl added the ui-copy Review of UI copy with docs team is recommended label Oct 11, 2022
@kibana-ci
Copy link
Collaborator

kibana-ci commented Oct 11, 2022

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 671.9KB 672.6KB +770.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@XavierM XavierM merged commit 2efcf7a into elastic:main Oct 11, 2022
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 11, 2022
* add ordering + bigger bucket for the KPI

* css cleanup

(cherry picked from commit 2efcf7a)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 11, 2022
* add ordering + bigger bucket for the KPI

* css cleanup

(cherry picked from commit 2efcf7a)

Co-authored-by: Xavier Mouligneau <xavier.mouligneau@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience ci:cloud-deploy Create or update a Cloud deployment impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) ui-copy Review of UI copy with docs team is recommended v8.5.0 v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A failed rule run is not shown as a failure response in Rule Logs KPI
8 participants