Creating alert link with alert id and rule id #140634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
3 tasks
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
fkanout
reviewed
Sep 14, 2022
| @@ -14,8 +14,10 @@ export const paths = { | |||
| rules: RULES_PAGE_LINK, | |||
| ruleDetails: (ruleId?: string | null) => | |||
| ruleId ? `${RULES_PAGE_LINK}/${encodeURI(ruleId)}` : RULES_PAGE_LINK, | |||
| alertDetails: (alertId?: string | null) => | |||
| alertId ? `${ALERT_PAGE_LINK}/${encodeURI(alertId)}` : ALERT_PAGE_LINK, | |||
| alertDetails: (alertId?: string | null, ruleId?: string | null) => | |||
There was a problem hiding this comment.
@benakansara, alertId and ruleId should not be optional arguments. But the PR is already merged
There was a problem hiding this comment.
@fkanout agreed, I think there is no use case where alertDetails() will be called without parameters. But in case it does, user will be redirected to Alerts page. It will not break the page. For code clarity, I agree to not make it optional. I will include this change in another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #139269
This PR is only for creating alert details page link with alert id and rule id.