-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Detection Engine] Adds 8.4 rules #138515
Conversation
@elasticmachine merge upstream |
x-pack/plugins/security_solution/server/lib/detection_engine/rules/prepackaged_rules/index.ts
Outdated
Show resolved
Hide resolved
…ules/prepackaged_rules/index.ts
file contained delta changes and symbols in it from local vscode. Fixed locally and attempted to push but changes did not take place. Fixed locally and copy pasted into GitHub editor.
Fixing local vscode delta changes and formatting. Changed locally and pushed but did not take place in Github. Fixed locally and then copy pasted contents of file into Github editor.
These were due to conflicts that were addressed locally in VSCode but still had delta comments in them and then made their way into the files which caused the jobs to fail. Fixed locally and then pushed but changes did not take affect for some odd reason so I edited each file in Github's editor with the local fixes and committed them, the following files caused these errors.
|
💔 Build FailedFailed CI Steps
Test Failures
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
@elastic/security-detections-response any potential insight into why this test failed? https://buildkite.com/elastic/kibana-pull-request/builds/64272#0182886d-8b78-44a0-ad8c-66a006c9fcd1 From the looks of it, something in the build job attempts to create an example rule and was expecting most of it to be blank but required_fields was added and it threw the error? Does this happen to be something on our end or the testing side? |
Closing this due to some original conflicts when the PR was created that I addressed but were likely due to local differences. Confirmed with @brokensound77 during his PR creation using the same Detection Rules tag release but no initial conflicts. The BuildKite job failures are consistent. |
Summary
Pull updates to detection rules from https://github.com/elastic/detection-rules/tree/395ae2c1d1e1d93ea7520300d4fb5000c58ae870.
Checklist
Delete any items that are not applicable to this PR.
uses sentence case text and includes i18n support