Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Make sure render is not called after destroy #138368

Merged
merged 1 commit into from
Aug 9, 2022
Merged

[Lens] Make sure render is not called after destroy #138368

merged 1 commit into from
Aug 9, 2022

Conversation

flash1293
Copy link
Contributor

Fixes #137958 by making sure the isDestroyed flag is set before anything else is happening and render isn't calling through if the embeddable is destroyed already

@flash1293 flash1293 added Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:skip Skip the PR/issue when compiling release notes Feature:Lens backport:skip This commit does not require backporting labels Aug 9, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@flash1293 flash1293 marked this pull request as ready for review August 9, 2022 10:46
@flash1293 flash1293 requested a review from a team as a code owner August 9, 2022 10:46
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@flash1293 flash1293 mentioned this pull request Aug 9, 2022
Merged
1 task
stratoula
stratoula approved these changes Aug 9, 2022
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM and 👏 for the unit test :)

@flash1293 flash1293 merged commit 8c209fd into elastic:main Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stratoula stratoula stratoula approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Embeddable has been destroyed error happened after interacting with the Embeddable
5 participants
@flash1293 @kibana-ci @elasticmachine @stratoula @kibanamachine