You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We'd like to move KPI charts to Lens Embeddables, so they will be compatible with custom dashboards.
This means some the layout of KPIs are changed.
The order of chart actions are arranged alphabetically.
The inspect modal is changed and more actions are available from the modal.
This PR is for cloud deployment, demo, and UI review, the actual implementation will be split into 3 smaller PRs:
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
Risk
Probability
Severity
Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space.
Low
High
Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks.
High
Low
Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled.
Medium
High
Unit tests will verify that any feature flag or plugin combination still results in our service operational.
@monina-n ,
Can you please review the new KPI cards on hosts / network / users page.
These charts are rendered by Lens Embeddable component, so the look and feel should be align with Lens.
There's a known limitation about the metric section: As the Embeddable component is rendered like a card,
we won't be able to maintain the layout (especially the gap between the icon and the subtitle as we don't know how long the number is anymore, we can only reserve a fixed space for the card)as what we had before, could you please find a new design for the metric section?
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
issue: #136409
We'd like to move KPI charts to Lens Embeddables, so they will be compatible with custom dashboards.
This means some the layout of KPIs are changed.
The order of chart actions are arranged alphabetically.
The inspect modal is changed and more actions are available from the modal.
This PR is for cloud deployment, demo, and UI review, the actual implementation will be split into 3 smaller PRs:
Hosts
Screen.Recording.2022-08-08.at.11.15.05.mov
Host details
Users

Network

Inspector
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers