[cft] Exit 1 if purge error #137733
Merged
[cft] Exit 1 if purge error #137733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This triggers a job failure if the purge-cloud-deployments script encounters an error. I'm attempting to debug why an instance was stuck online and hoping this will make future issues easier to spot.
|
Pinging @elastic/kibana-operations (Team:Operations) |
brianseeders
reviewed
Aug 1, 2022
| @@ -45,6 +45,7 @@ for (const deployment of prDeployments) { | |||
| } catch (ex) { | |||
| console.error(ex.toString()); | |||
| // deploymentsToPurge.push(deployment); // TODO should we delete on error? | |||
| process.exit(1); | |||
There was a problem hiding this comment.
You should probably keep track of whether or not an error occurred, and then exit at the very end of the script, right? Otherwise, an error on the first deployment would keep all of the other ones from getting purged?
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
brianseeders
approved these changes
Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This triggers a job failure if the purge-cloud-deployments script
encounters an error. I'm attempting to debug why an instance was stuck
online and hoping this will make future issues easier to spot.