Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Fixes the styling issue of dropping a geo field #137510

Merged
merged 3 commits into from
Aug 1, 2022
Merged

[Lens] Fixes the styling issue of dropping a geo field #137510

merged 3 commits into from
Aug 1, 2022

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Jul 28, 2022 •
edited by kibanamachine
Loading

Summary

Closes #137320

It fixes the ugly styling that appears when dropping a geo field. This was caused by some emotion changes on the EUI side.

Screenshot 2022-07-28 at 8 16 57 PM

@stratoula stratoula added Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) labels Jul 28, 2022
@stratoula stratoula marked this pull request as ready for review July 28, 2022 17:22
@stratoula stratoula requested a review from a team as a code owner July 28, 2022 17:22
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

drewdaemon
drewdaemon approved these changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@drewdaemon drewdaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.2MB 1.2MB +26.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula merged commit c26e085 into elastic:main Aug 1, 2022
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 1, 2022
@stratoula
[Lens] Fixes the styling issue of dropping a geo field (elastic#137510)
63b8c8f 
(cherry picked from commit c26e085)
@kibanamachine kibanamachine mentioned this pull request Aug 1, 2022
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.4

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Aug 1, 2022
@kibanamachine @stratoula
[Lens] Fixes the styling issue of dropping a geo field (#137510) (#13…
71713da 
…7656)

(cherry picked from commit c26e085)

Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewdaemon drewdaemon drewdaemon approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.4.0 v8.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Lens] geo fields drop view is goofed up
5 participants
@stratoula @elasticmachine @kibana-ci @kibanamachine @drewdaemon