Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change rule filter button text #136709

Closed
wants to merge 8 commits into from
Closed

Change rule filter button text #136709

wants to merge 8 commits into from

Conversation

benakansara
Copy link
Contributor

@benakansara benakansara commented Jul 20, 2022 •
edited
Loading

Summary

Changes filter button text from View to State in Rules' list page.

Fixes #136301

New translations for FR, JP and CN need to be added for the text State. @elastic/response-ops, @elastic/actionable-observability Please let me know how can I request for these translations to be added.

@benakansara benakansara added the Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" label Jul 20, 2022
@benakansara benakansara requested a review from fkanout July 20, 2022 09:51
@benakansara benakansara added v8.4.0 release_note:skip Skip the PR/issue when compiling release notes labels Jul 20, 2022
@benakansara
Copy link
Contributor Author

@elasticmachine merge upstream

@emma-raffenne emma-raffenne removed their request for review July 20, 2022 13:19
@benakansara
Copy link
Contributor Author

/oblt-deploy

@benakansara
Copy link
Contributor Author

@elasticmachine merge upstream

@benakansara benakansara marked this pull request as ready for review July 20, 2022 13:33
@benakansara benakansara requested a review from a team as a code owner July 20, 2022 13:33
@benakansara benakansara changed the title Ao/136301 update view filter title Change rule filter button text Jul 20, 2022
fkanout
fkanout approved these changes Jul 22, 2022
View reviewed changes
Copy link
Contributor

@fkanout fkanout left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good job, @benakansara. Thank you for the effort tracking the i18n 👍🏻

@fkanout
Copy link
Contributor

fkanout commented Jul 25, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@XavierM
Copy link
Contributor

XavierM commented Jul 26, 2022 •
edited
Loading

Hello @benakansara, I am doing that instead of just renaming to state

#136282 (comment)

it will be in this PR -> #136148

@benakansara benakansara deleted the ao/136301-update-view-filter-title branch August 11, 2022 16:59
@benakansara
Copy link
Contributor Author

Closing this PR as the fix is implemented in different PR #136148 as per changed requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fkanout fkanout fkanout approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Actionable observability] Update View filter title in Rules' list page
5 participants
@benakansara @fkanout @kibana-ci @XavierM @kibanamachine