Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Data Visualizer: Remove import reference for users without import privileges #135905

Merged

Conversation

peteharverson
Copy link
Contributor

Summary

Removes reference to import the data into an Elasticsearch index from the about screen in the file data visualizer for users without the necessary privileges to import data. Previously the inclusion of this text for all users, regardless of privileges, might have given an incorrect impression that they could import data into an index.

Part of #106617

Users without ability to import data:
image

Full text displayed for users with ability to import data:
image

@peteharverson peteharverson added review :ml release_note:skip Skip the PR/issue when compiling release notes Feature:File and Index Data Viz ML file and index data visualizer v8.4.0 labels Jul 7, 2022
@peteharverson peteharverson requested a review from a team as a code owner July 7, 2022 13:31
@peteharverson peteharverson self-assigned this Jul 7, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dataVisualizer 543.7KB 544.0KB +279.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @peteharverson

@qn895
Copy link
Member

qn895 commented Jul 7, 2022

Tested and LGTM 🎉

@peteharverson peteharverson merged commit d779e53 into elastic:main Jul 7, 2022
@peteharverson peteharverson deleted the data-visualizer-no-import-text branch July 7, 2022 15:06
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:File and Index Data Viz ML file and index data visualizer :ml release_note:skip Skip the PR/issue when compiling release notes review v8.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants