Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TSVB] Fix css specificity issue #135245

Merged
merged 1 commit into from
Jun 29, 2022
Merged

[TSVB] Fix css specificity issue #135245

merged 1 commit into from
Jun 29, 2022

Conversation

flash1293
Copy link
Contributor

Fixes #134878

By adding another class selector to every rule to beat the base styles.

@flash1293 flash1293 added Feature:TSVB TSVB (Time Series Visual Builder) release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure backport:skip This commit does not require backporting v8.4.0 labels Jun 27, 2022
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #24 / Saved Objects Management "after all" hook: afterTestSuite.trigger in "Saved Objects Management"
  • [job] [logs] FTR Configs #24 / Saved Objects Management import warnings "after all" hook: afterTestSuite.trigger for "should display warnings coming from multiple types"
  • [job] [logs] FTR Configs #24 / Saved Objects Management import warnings "before each" hook for "should display simple warnings"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visTypeTimeseries 450.1KB 450.1KB +64.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@flash1293 flash1293 marked this pull request as ready for review June 28, 2022 07:36
@flash1293 flash1293 requested a review from a team as a code owner June 28, 2022 07:36
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

drewdaemon
drewdaemon approved these changes Jun 28, 2022
View reviewed changes
Copy link
Contributor

@drewdaemon drewdaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected 👍

@flash1293 flash1293 merged commit 4a62017 into elastic:main Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewdaemon drewdaemon drewdaemon approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:TSVB TSVB (Time Series Visual Builder) release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TSVB] Some css properties on markdown styling need !important to be applied
4 participants
@flash1293 @kibana-ci @elasticmachine @drewdaemon