[Security Solution] bubble up policy response errors #133349
Conversation
| i18n.translate( | ||
| 'xpack.securitySolution.endpoint.details.policyResponse.link.text.full_disk_access', | ||
| { | ||
| defaultMessage: 'Documentation', |
There was a problem hiding this comment.
@kevinlog thoughts on wording for full_disk_access link button?
There was a problem hiding this comment.
how about: Full disk access needs to be enabled on this host to enable all Endpoint capabilities. See the documentation[link] for more information.
cc @caitlinbetz
There was a problem hiding this comment.
I do agree that using the link within the description is more elegant. though, I also feel like since the design had a CTA button it felt a bit more consistent if all links were just on the button. either way works for me though.
| this.title = | ||
| policyResponseTitles.get(this.name) ?? | ||
| this.name.replace(/_/g, ' ').replace(/\b(\w)/g, (m) => m.toUpperCase()); | ||
| this.hasError = policyResponseAppliedAction.status === 'failure'; |
There was a problem hiding this comment.
@kevinlog should we also show callout on unsupported or warning?
There was a problem hiding this comment.
we should show a callout for warning, but no need for unsupported at this time.
d680bb9 to
5828bfd
Compare
|
Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt) |
💚 Build SucceededMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Tested it out and it works as expected. Since this is to make the error handling UX better, it got me thinking, that currently, you can see where the error is with the notification bubble, but still have to click a couple of times to get to it depending on which level it is in.
It might be even more helpful if the bubbled-up callout title was clickable to expand the policy where the error is. What do you think?
| const key = action + index; | ||
| return ( | ||
| <EuiAccordion | ||
| id={action + index} | ||
| key={action + index} | ||
| id={key} | ||
| key={key} |
| color="danger" | ||
| iconType="alert" | ||
| > | ||
| <p style={{ marginBottom: '8px' }}>{policyResponseError.errorDescription}</p> |
There was a problem hiding this comment.
You should pull this from the euiTheme, there must be a token like euiMarginBottom or something.
I think this is a good idea. Though, I think the implementation might be a bit too involved with manual accordion state tracking. I feel like in a normal scenario, a user wouldn't need to drill down the accordion and the top level callout should be sufficient at providing enough actionable information. |
|
Closing this PR for now as there's a decent amount of overlap with this PR: #133405. Will reopen after it is merged and reimplement the necessary changes. |
Summary
policy_response_friendly_names.tsso that new error descriptions and links can easily be added.full_disk_accessas failure actionTesting notes:
linkTextsandlinkUrls.descriptions.Checklist
Delete any items that are not applicable to this PR.
For maintainers