Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove injectedMetadata in vega #132521

Merged
merged 3 commits into from
May 20, 2022
Merged

Remove injectedMetadata in vega #132521

merged 3 commits into from
May 20, 2022

Conversation

VladLasitsa
Copy link
Contributor

Completes part of #128872

Summary

As core.injectedMetadata is deprecated, this has been removed from vega. Vega has already get the all the necessary configs from map_ems plugin.

@VladLasitsa VladLasitsa self-assigned this May 19, 2022
@VladLasitsa VladLasitsa added Feature:Vega Vega visualizations Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.3.0 labels May 19, 2022
@VladLasitsa
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visTypeVega 1.7MB 1.7MB -31.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
visTypeVega 33.2KB 33.0KB -225.0B
Unknown metric groups

References to deprecated APIs

id before after diff
visTypeVega 3 0 -3

Unreferenced deprecated APIs

id before after diff
core 3 4 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @VladLasitsa

@VladLasitsa VladLasitsa marked this pull request as ready for review May 20, 2022 07:23
@VladLasitsa VladLasitsa requested a review from a team as a code owner May 20, 2022 07:23
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

flash1293
flash1293 approved these changes May 20, 2022
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VladLasitsa VladLasitsa merged commit 968f7a9 into elastic:main May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flash1293 flash1293 flash1293 approved these changes

Assignees

@VladLasitsa VladLasitsa

Labels
backport:skip This commit does not require backporting Feature:Vega Vega visualizations release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@VladLasitsa @kibana-ci @elasticmachine @flash1293 @kibanamachine