Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Actionable Observability] Add execution log count in the last 24h in the Rule details page #132411

Merged
merged 4 commits into from
May 20, 2022

Conversation

fkanout
Copy link
Contributor

@fkanout fkanout commented May 18, 2022

Summary

it fixes #132410 by adding the number of the execution log in the last 24h

Checklist

@fkanout fkanout added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.3.0 labels May 18, 2022
@fkanout fkanout requested a review from a team as a code owner May 18, 2022 11:36
@fkanout fkanout self-assigned this May 18, 2022
@fkanout
Copy link
Contributor Author

fkanout commented May 20, 2022

@elasticmachine merge upstream

Copy link
Contributor

@katrin-freihofner katrin-freihofner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
observability 409 410 +1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
triggersActionsUi 370 372 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 452.3KB 453.6KB +1.3KB
triggersActionsUi 786.3KB 786.3KB +1.0B
total +1.3KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
triggersActionsUi 115.5KB 115.6KB +162.0B
Unknown metric groups

API count

id before after diff
triggersActionsUi 384 386 +2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @fkanout

Copy link
Contributor

@gmmorris gmmorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RO export of loadExecutionLogAggregations LGTM

cc @XavierM re bundle size concerns, but no need to block O11y on that.

@fkanout fkanout merged commit c136515 into elastic:main May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the last 24h execution log count in the Rule details page
5 participants