[Stack Monitoring] Use server.publicBaseUrl in Alert links #131154
Conversation
|
Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI) |
| @@ -344,6 +344,9 @@ export class BaseRule { | |||
| if (ccs) { | |||
| globalState.push(`ccs:${ccs}`); | |||
| } | |||
| return `${Globals.app.url}/app/monitoring#/${link}?_g=(${globalState.toString()})`; | |||
|
|
|||
| const baseUrl = Globals.app.url || '(server.publicBaseUrl)'; | |||
There was a problem hiding this comment.
I don't know how we should react if the setting isn't configured, the default is simply 'undefined'.
There was a problem hiding this comment.
We could use the serverInfo as a fallback, or make it a relative path URL.
There was a problem hiding this comment.
We expose the kibana base path itself as an action context variable within alerting, and leave it "set" to undefined if the config is not set. It renders as the empty string. Customers can "optionally" add it via a section block like, so it won't render anything if it's undefined:
Note you can one-line this multi-line template.
{{#kibanaBaseUrl}}
[head to Kibana]({{kibanaBaseUrl}})
{{/kibanaBaseUrl}}
|
|
||
| const baseUrl = Globals.app.url || '(server.publicBaseUrl)'; | ||
|
|
||
| return `${baseUrl}/app/monitoring#/${link}?_g=(${globalState.toString()})`; |
There was a problem hiding this comment.
Since the input may be coming from the user (cloud sets the kibanaBaseUrl and it's not overridable by customers), would be best to use something like a relative URL "joiner" (not sure what the current flavor would be). Reason is, the customer may or may not be adding an trailing / to the URL, and you don't want to generate ...//app/... (though that might well work in some envs)
I believe I've cheated and used path.join() for this as well, but ... using a url or URL or whatever is correct these days would be better.
There was a problem hiding this comment.
The Kibana docs state this value cannot end in /, so this should be safe?
I tested a few different configuration and kept getting errors about this so Kibana wouldn't start.
There was a problem hiding this comment.
Ah, if that's the case, shouldn't need a special join!
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
…31154) * [Stack Monitoring] Use server.publicBaseUrl in Alert links (elastic#127126) * Use empty string as fallback value Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Fixes #127126
Rather than reading from core.Http. getServerInfo which gives info about the internal host, we use the config setting server.publicBaseUrl which should be set to the public facing URL users reach Kibana on when generating the links in alerts.