Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci-stats-reporter] use v2 test group APIs #131001

Merged
merged 8 commits into from
Apr 27, 2022

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Apr 26, 2022

The v1 version of the test group API supported writing all of the test run data in a single request, which was convenient but also requires some parsing magic in the API to handle correctly, and when an error occurs somewhere in the middle of that magic the data written might be inconsistent. v2 of the API breaks the calls up to reduce the likelihood of these errors and reduce the memory overhead of each request. This implements this version of the API in main and will be used going forward.

@spalger spalger force-pushed the implement/v2-test-group-api branch from d13e1fd to e1a4cf4 Compare April 26, 2022 17:19
@spalger spalger added Team:Operations Team label for Operations Team release_note:skip Skip the PR/issue when compiling release notes v8.3.0 labels Apr 26, 2022
@spalger spalger marked this pull request as ready for review April 27, 2022 00:52
@spalger spalger requested a review from a team as a code owner April 27, 2022 00:52
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@spalger spalger enabled auto-merge (squash) April 27, 2022 18:10
@spalger spalger merged commit 7fd1661 into elastic:main Apr 27, 2022
@spalger spalger deleted the implement/v2-test-group-api branch April 27, 2022 18:16
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Apr 27, 2022
@spalger spalger added v8.2.1 v7.17.4 auto-backport Deprecated - use backport:version if exact versions are needed and removed backport:skip This commit does not require backporting labels May 3, 2022
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.2 Backport failed because of merge conflicts
7.17 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 131001

Questions ?

Please refer to the Backport tool documentation

spalger pushed a commit to spalger/kibana that referenced this pull request May 3, 2022
* [ci-stats-reporter] use v2 test group APIs

* fix bazel deps

* [CI] Auto-commit changed files from 'yarn kbn run build -i @kbn/pm'

* avoid importing kbn/std in kbn-pm

* removed kbn/std dependency

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 7fd1661)

# Conflicts:
#	packages/kbn-pm/dist/index.js
spalger pushed a commit to spalger/kibana that referenced this pull request May 3, 2022
* [ci-stats-reporter] use v2 test group APIs

* fix bazel deps

* [CI] Auto-commit changed files from 'yarn kbn run build -i @kbn/pm'

* avoid importing kbn/std in kbn-pm

* removed kbn/std dependency

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 7fd1661)

# Conflicts:
#	packages/kbn-pm/dist/index.js
spalger pushed a commit that referenced this pull request May 3, 2022
* [ci-stats-reporter] use v2 test group APIs (#131001)

* [ci-stats-reporter] use v2 test group APIs

* fix bazel deps

* [CI] Auto-commit changed files from 'yarn kbn run build -i @kbn/pm'

* avoid importing kbn/std in kbn-pm

* removed kbn/std dependency

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 7fd1661)

# Conflicts:
#	packages/kbn-pm/dist/index.js

* [ci-stats-reporter] use a default timeout of 60 seconds (#131428)

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 06b958d)
spalger pushed a commit that referenced this pull request May 3, 2022
* [ci-stats-reporter] use v2 test group APIs (#131001)

* [ci-stats-reporter] use v2 test group APIs

* fix bazel deps

* [CI] Auto-commit changed files from 'yarn kbn run build -i @kbn/pm'

* avoid importing kbn/std in kbn-pm

* removed kbn/std dependency

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 7fd1661)

# Conflicts:
#	packages/kbn-pm/dist/index.js

* [ci-stats-reporter] use a default timeout of 60 seconds (#131428)

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 06b958d)
kertal pushed a commit to kertal/kibana that referenced this pull request May 24, 2022
* [ci-stats-reporter] use v2 test group APIs

* fix bazel deps

* [CI] Auto-commit changed files from 'yarn kbn run build -i @kbn/pm'

* avoid importing kbn/std in kbn-pm

* removed kbn/std dependency

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.17.4 v8.2.1 v8.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants