-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Stack Monitoring] Convert elasticsearch routes to TypeScript #130969
Merged
weltenwort
merged 15 commits into
elastic:main
from
weltenwort:monitoring-ts-convert-routes-elasticsearch
Apr 28, 2022
Merged
[Stack Monitoring] Convert elasticsearch routes to TypeScript #130969
weltenwort
merged 15 commits into
elastic:main
from
weltenwort:monitoring-ts-convert-routes-elasticsearch
Apr 28, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
73221aa
to
1ebc79f
Compare
π Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @weltenwort |
Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI) |
Kerry350
approved these changes
Apr 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM β
Thanks for adding the type inference on LegacyRequest
and expanding the shared types π
kertal
pushed a commit
to kertal/kibana
that referenced
this pull request
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:skip
This commit does not require backporting
Feature:Stack Monitoring
release_note:skip
Skip the PR/issue when compiling release notes
Team:Infra Monitoring UI - DEPRECATED
DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
v8.3.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Summary
This converts the elasticsearch-specific stack monitoring routes to TypeScript.
closes #117760
π΅οΈββοΈ Review notes
validateParams
,validateQuery
andvalidateBody
functions for each route. That way the correct request type is fixed and made available to thereq
argument of the route registration function. I also retrofitted that to the already converted APM and beats routes.timeRange
request param type performs the conversion to an epoch directly while decoding so I remove several downstreammoment
usages.getClusterStats
andgetPaginatedNodes
don't actually take accs
argument but the routes passed it as the last argument. It never took effect so I removed it.