Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Current state help popover #130009

Merged
merged 8 commits into from
Apr 29, 2022
Merged

Current state help popover #130009

merged 8 commits into from
Apr 29, 2022

Conversation

flash1293
Copy link
Contributor

@flash1293 flash1293 commented Apr 12, 2022 •
edited
Loading

Fixes #87322

Screenshot 2022-04-27 at 18 04 04

Screenshot 2022-04-27 at 18 04 00

@flash1293 flash1293 added Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:skip Skip the PR/issue when compiling release notes Feature:Lens backport:skip This commit does not require backporting v8.3.0 and removed skip-ci labels Apr 27, 2022
@flash1293
Copy link
Contributor Author

@elasticmachine merge upstream

@flash1293
Copy link
Contributor Author

@MichaelMarcialis could you have a look at this? It seems to work fine, but just to make sure.

@flash1293 flash1293 marked this pull request as ready for review April 28, 2022 09:25
@flash1293 flash1293 requested review from a team as code owners April 28, 2022 09:25
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

MichaelMarcialis
MichaelMarcialis reviewed Apr 28, 2022
View reviewed changes
Copy link
Contributor

@MichaelMarcialis MichaelMarcialis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together, @flash1293. I've left you a few comments below for your review.

@flash1293
Copy link
Contributor Author

Thanks @MichaelMarcialis , addressed those

@flash1293
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.1MB 1.1MB +727.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

MichaelMarcialis
MichaelMarcialis approved these changes Apr 29, 2022
View reviewed changes
Copy link
Contributor

@MichaelMarcialis MichaelMarcialis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for addressing those comments, @flash1293!

drewdaemon
drewdaemon reviewed Apr 29, 2022
View reviewed changes
Copy link
Contributor

@drewdaemon drewdaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! (Code review only)

@KOTungseth
Copy link
Contributor

Text LGTM

@flash1293 flash1293 merged commit 61364dc into elastic:main Apr 29, 2022
kertal pushed a commit to kertal/kibana that referenced this pull request May 24, 2022
@flash1293 @kertal
Current state help popover (elastic#130009)
25e5224
@jughosta jughosta mentioned this pull request Jun 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewdaemon drewdaemon drewdaemon approved these changes

@MichaelMarcialis MichaelMarcialis MichaelMarcialis approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Lens] Move function help popover triggers to extraAction in related EuiListGroupItem
7 participants
@flash1293 @elasticmachine @kibana-ci @KOTungseth @drewdaemon @MichaelMarcialis @kibanamachine