Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Update document explorer callout wording #128556

Merged
merged 11 commits into from
Mar 30, 2022

Conversation

dimaanj
Copy link
Contributor

@dimaanj dimaanj commented Mar 25, 2022

Summary

Part of #126604

New Document Explorer callout

4A94F079-9EF8-48A3-8C28-C5EFD1E2FAC2_4_5005_c

Classic table callout (now Document Explorer has semi-bold font weight)

82E7B412-9024-4B36-8673-59CECF8796FD_4_5005_c

Document Explorer setting (now Document Explorer has semi-bold font weight)

5523E471-FF58-4D2E-ACEC-49B602DA47B4_4_5005_c

Checklist

@dimaanj dimaanj added Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.2.0 labels Mar 25, 2022
@dimaanj dimaanj self-assigned this Mar 25, 2022
@dimaanj
Copy link
Contributor Author

dimaanj commented Mar 26, 2022

@elasticmachine merge upstream

@dimaanj dimaanj marked this pull request as ready for review March 28, 2022 05:32
@dimaanj dimaanj requested a review from a team as a code owner March 28, 2022 05:32
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

- less seperate FormattedMessage usage
@kertal
Copy link
Member

kertal commented Mar 29, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
discover 432 433 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 381.2KB 383.5KB +2.2KB
Unknown metric groups

ESLint disabled in files

id before after diff
apm 15 14 -1
osquery 5 4 -1
securitySolution 69 68 -1
uptime 7 6 -1
total -4

ESLint disabled line counts

id before after diff
apm 88 85 -3
enterpriseSearch 9 7 -2
fleet 47 46 -1
osquery 122 119 -3
uptime 49 43 -6
total -15

References to deprecated APIs

id before after diff
canvas 70 64 -6
dashboard 78 72 -6
data 475 465 -10
dataEnhanced 55 49 -6
discover 26 20 -6
fleet 20 19 -1
lens 18 14 -4
management 2 1 -1
maps 456 330 -126
monitoring 40 28 -12
upgradeAssistant 12 7 -5
visDefaultEditor 205 155 -50
visTypeVega 4 3 -1
visualizations 17 13 -4
total -238

Total ESLint disabled count

id before after diff
apm 103 99 -4
enterpriseSearch 9 7 -2
fleet 55 54 -1
osquery 127 123 -4
securitySolution 509 508 -1
uptime 56 49 -7
total -19

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dmitriynj

Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested in Safari, Firefox, Chrome, works as expected

@kertal kertal merged commit d0c06b0 into elastic:main Mar 30, 2022
@kertal kertal added the backport:skip This commit does not require backporting label Mar 30, 2022
@tylersmalley tylersmalley added ci:cloud-deploy Create or update a Cloud deployment and removed ci:deploy-cloud labels Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting ci:cloud-deploy Create or update a Cloud deployment Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants