Fix unhandled alias search errors #128289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The data plugin already defined this function, I just moved it to the @kbn/es-kuery package so other consumers could use it too.
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
logeekal
added a commit
to logeekal/kibana
that referenced
this pull request
Nov 4, 2024
logeekal
added a commit
that referenced
this pull request
Dec 3, 2024
… grammer (#198288) ## Summary As mentioned in https://github.com/elastic/kibana/security/code-scanning/349, this PR resolves the escaping issue. Additionally, it also adds more candiadates for escaping as mentioned in `kuery` grammar as shown below . https://github.com/elastic/kibana/blob/d6b4fe9e6ee2e18691b0fa818c4e2c4ed3c413fc/packages/kbn-es-query/grammar/grammar.peggy#L295-L298 ## Solution This PR replicates #128289 in `7.17` where `escape_kquery` was moved from `data` plugin to `es-query` package. This should have been backported to `7.17` but was not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #128282.
This fixes certain edge cases that could cause the ES kuery builder to throw an unexpected error when a saved object ID contains a
:character.This is a bug fix, but I'm labeling this as
release_note:skipbecause this bug doesn't have any practical impact on users in past versions of Kibana.