Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CTI] updates CTI card table title size #128273

Merged
merged 2 commits into from
Mar 22, 2022
Merged

[CTI] updates CTI card table title size #128273

merged 2 commits into from
Mar 22, 2022

Conversation

ecezalp
Copy link
Contributor

@ecezalp ecezalp commented Mar 22, 2022

Summary

before
Screen Shot 2022-03-22 at 10 44 03 AM

after
Screen Shot 2022-03-22 at 10 26 30 AM

@ecezalp ecezalp added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:Detections and Resp Security Detection Response Team Team: CTI v8.2.0 labels Mar 22, 2022
@ecezalp ecezalp self-assigned this Mar 22, 2022
@ecezalp ecezalp requested a review from a team as a code owner March 22, 2022 14:47
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@ecezalp ecezalp enabled auto-merge (squash) March 22, 2022 14:49
@ecezalp ecezalp mentioned this pull request Mar 22, 2022
Closed
@yiyangliu9286
Copy link

yiyangliu9286 commented Mar 22, 2022 •
edited
Loading

I have discussed this with @ecezalp and the design fix is approved ✅.

@ecezalp
Copy link
Contributor Author

ecezalp commented Mar 22, 2022

@elasticmachine merge upstream

@ecezalp ecezalp merged commit 2e33dd4 into elastic:main Mar 22, 2022
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Test Failures

  • [job] [logs] Security Solution Tests / Marking alerts as acknowledged with read only role Mark one alert as acknowledged when more than one open alerts are selected

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 4.8MB 4.8MB +1.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @ecezalp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkhristinin nkhristinin nkhristinin approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team: CTI Team:Detections and Resp Security Detection Response Team v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ecezalp @elasticmachine @yiyangliu9286 @kibana-ci @nkhristinin @kibanamachine