Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cases] Allow custom toast title and content in cases hooks #128145

Merged

Conversation

academo
Copy link
Contributor

@academo academo commented Mar 21, 2022

Summary

Closes: #127968

Updated logic:

if any custom title or content is passed, those will display.
If at least one of the passed attachments is an alert, the toast will show an alert-specific message.
if none of the attachments are alerts, or no attachments are passed. The toast will show a "generic" updated title and no content.

For all cases the "view case" link will show.

@academo academo added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Cases Cases feature v8.2.0 labels Mar 21, 2022
@academo academo self-assigned this Mar 21, 2022
@academo academo added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Mar 21, 2022
@academo academo marked this pull request as ready for review March 21, 2022 13:36
@academo academo requested a review from a team as a code owner March 21, 2022 13:36
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops-cases (Feature:Cases)

@academo
Copy link
Contributor Author

academo commented Mar 22, 2022

@elasticmachine merge upstream

1 similar comment
@academo
Copy link
Contributor Author

academo commented Mar 22, 2022

@elasticmachine merge upstream

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cnasikas cnasikas added the bug Fixes for quality problems that affect the customer experience label Mar 23, 2022
@academo academo force-pushed the enhancement/cases-custom-toast-messsage-for-hooks branch from d83d52a to f682a6a Compare March 23, 2022 12:33
@academo academo requested a review from peteharverson March 23, 2022 12:33
Copy link
Member

@cnasikas cnasikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM!

@academo academo enabled auto-merge (squash) March 23, 2022 15:22
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cases 292.5KB 292.5KB +4.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
cases 85.1KB 85.9KB +841.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @academo

@academo academo merged commit 55e42ce into elastic:main Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting bug Fixes for quality problems that affect the customer experience Feature:Cases Cases feature release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Cases] Allow toast message customization of the create-case and select-case hooks with attachment
6 participants