Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[XY] system_palette and palette support. #128053

Merged
merged 87 commits into from
Mar 29, 2022
Merged

[XY] system_palette and palette support. #128053

merged 87 commits into from
Mar 29, 2022

Conversation

Kuznietsov
Copy link
Contributor

@Kuznietsov Kuznietsov commented Mar 18, 2022 •
edited
Loading

Summary

  • Added palette and system_palette types to the palette arg of dataLayer expression function.

Kuznietsov and others added 30 commits March 8, 2022 16:08
@Kuznietsov
added xy plugin.
9388bba
@kibanamachine
Merge branch 'main' into chart_expressions-xy
8df9659
@Kuznietsov
Added expressionXY limits.
ab72728
@Kuznietsov
Merge branch 'chart_expressions-xy' of github.com:Kunzetsov/kibana in…
5747322 
…to chart_expressions-xy
@Kuznietsov
Added xy expression functions to the expression_xy plugin.
b4ee9c1
@Kuznietsov
Moved xy to a separate plugin.
400845d
@Kuznietsov
Small refactoring.
b2090f3
@Kuznietsov
Fixed types.
33a06fa
@Kuznietsov
Merge branch 'main' into chart_expressions-xy
d94fa4f 
# Conflicts:
#	src/plugins/chart_expressions/expression_xy/common/expression_functions/legend_config.ts
#	x-pack/plugins/lens/public/xy_visualization/visualization.tsx
@Kuznietsov
Fixed import of scss.
663e093
@Kuznietsov
Fixed imports.
cbffe77
@Kuznietsov
Added required plugins.
389f933
@Kuznietsov
Fixed import
90aa97a
@Kuznietsov
Fixed types.
1d3a264
@Kuznietsov
Changed expression names.
a78d45d
@Kuznietsov
Fixed bugs, caused by the refactoring process.
35cab91
@kibanamachine
Merge branch 'main' into chart_expressions-xy
847b3c4
@Kuznietsov
Fixed lens snapshots.
ed7f8ea
@Kuznietsov
Removed new line.
b6daa5d
@Kuznietsov
Merge branch 'chart_expressions-xy' of github.com:Kunzetsov/kibana in…
bda6524 
…to chart_expressions-xy
@Kuznietsov
Fixed xy_chart tests.
c8d40fe
@Kuznietsov
Added lazy loading for xy chart.
5fed60c
@Kuznietsov
Fixed xy chart test.
dc195b2
@Kuznietsov
Fixed broken chart selectors.
d39681f
@Kuznietsov
Fixed dashboard tests.
b901d68
@Kuznietsov
dashboard test fixed.
d327dfe
@Kuznietsov
Fixed heatmap vis.
b500961
@Kuznietsov
Smokescreen test fixed.
7a25b74
@Kuznietsov
more fixes.
0004794
@Kuznietsov
async dashboard tests fixed.
fc8c0b3
Kuznietsov and others added 21 commits March 24, 2022 21:34
@Kuznietsov
First try to fix merge conflicts.
21e34b4
@Kuznietsov
Fixed annotatations.
9cc22c8
@Kuznietsov
Fixed types.
a99a223
@Kuznietsov
Updated snapshots
b553456
@Kuznietsov
Merge branch 'main' into chart_expressions-xy
60f5645 
# Conflicts:
#	x-pack/plugins/lens/common/expressions/xy_chart/xy_chart.ts
#	x-pack/plugins/lens/public/editor_frame_service/editor_frame/config_panel/layer_panel.tsx
#	x-pack/plugins/lens/public/xy_visualization/expression.test.tsx
@Kuznietsov
Fixed tests.
dec0d18
@Kuznietsov
Fixed dependencies.
628ade6
@Kuznietsov
Fixed i18n.
cc63956
@Kuznietsov
Moved XY state types to lens.
0e4092d
@Kuznietsov
Fixed more types.
ef30205
@Kuznietsov
Merge branch 'main' into chart_expressions-xy
f29bdcf
@Kuznietsov
Merge branch 'chart_expressions-xy' into chart_expressions-xy-palette
7477cee
@Kuznietsov @mbondyra
Update src/plugins/chart_expressions/expression_xy/README.md
8139986 
Co-authored-by: Marta Bondyra <marta.bondyra@gmail.com>
@kibanamachine
[CI] Auto-commit changed files from 'node scripts/build_plugin_list_d…
8307b73 
…ocs'
@Kuznietsov
Removed yConfig from *Layers types
500fb78
@Kuznietsov
Fixed styles.
839b023
@Kuznietsov
Fixed types.
b61e59a
@Kuznietsov
Removed not used utils and styles.
53a6659
@Kuznietsov
Merge branch 'main' into chart_expressions-xy
490159a 
# Conflicts:
#	x-pack/test/functional/apps/lens/show_underlying_data.ts
@Kuznietsov
Merge branch 'chart_expressions-xy' into chart_expressions-xy-palette
9a527d7
@Kuznietsov
Merge branch 'main' into chart_expressions-xy-palette
eacb61e 
# Conflicts:
#	src/plugins/chart_expressions/expression_xy/common/expression_functions/data_layer_config.ts
#	x-pack/plugins/enterprise_search/public/applications/enterprise_search_overview/components/elasticsearch_card/index.ts
#	x-pack/plugins/lens/public/xy_visualization/__snapshots__/to_expression.test.ts.snap
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.1MB 1.1MB +65.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
expressionXY 40.1KB 40.1KB -32.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @Kunzetsov

@Kuznietsov Kuznietsov marked this pull request as ready for review March 29, 2022 08:10
@Kuznietsov Kuznietsov requested a review from a team as a code owner March 29, 2022 08:10
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

mbondyra
mbondyra approved these changes Mar 29, 2022
View reviewed changes
Copy link
Contributor

@mbondyra mbondyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Chrome, works as expected. Code LGTM 👌🏼

@Kuznietsov Kuznietsov merged commit 2dcdbbe into elastic:main Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbondyra mbondyra mbondyra approved these changes

@alexwizp alexwizp Awaiting requested review from alexwizp

@stratoula stratoula Awaiting requested review from stratoula

@flash1293 flash1293 Awaiting requested review from flash1293

@crob611 crob611 Awaiting requested review from crob611

Assignees

@Kuznietsov Kuznietsov

Labels
backport:skip This commit does not require backporting Feature:Lens impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort NeededFor:VisEditors release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Kuznietsov @kibana-ci @elasticmachine @mbondyra @kibanamachine