Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Add documentation links for Document Explorer #127971

Merged
merged 4 commits into from
Mar 21, 2022
Merged

[Discover] Add documentation links for Document Explorer #127971

merged 4 commits into from
Mar 21, 2022

Conversation

dimaanj
Copy link
Contributor

@dimaanj dimaanj commented Mar 17, 2022

Summary

Closes #126604

This PR adds links to Document Explorer documentation from advanced settings and discover legacy table callout.

4436F2E4-CFB1-48C6-862D-4CD021978E5A_4_5005_c

81ADA464-4F72-44AA-85C8-AB5B3D589D0D_4_5005_c

Checklist

  • Documentation was added for features that require explanation or tutorials
  • This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)

@dimaanj dimaanj added Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.1.1 labels Mar 17, 2022
@dimaanj dimaanj self-assigned this Mar 17, 2022
@dimaanj dimaanj marked this pull request as ready for review March 18, 2022 09:12
@dimaanj dimaanj requested review from a team as code owners March 18, 2022 09:12
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

lcawl
lcawl approved these changes Mar 18, 2022
View reviewed changes
Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addition to the doc link service LGTM, thanks!

@kertal kertal added the v8.2.0 label Mar 18, 2022
kertal
kertal approved these changes Mar 18, 2022
View reviewed changes
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested with local cloud deployment in Safari, works as expected, thx Dima 👍

@dimaanj
Copy link
Contributor Author

dimaanj commented Mar 21, 2022

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

expected head sha didn’t match current head ref.

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 380.5KB 380.8KB +341.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 295.9KB 295.9KB +46.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dmitriynj

@spalger
Copy link
Contributor

spalger commented Mar 21, 2022

cla/check

@dimaanj dimaanj added the auto-backport Deprecated - use backport:version if exact versions are needed label Mar 21, 2022
@dimaanj dimaanj merged commit ee62fe8 into elastic:main Mar 21, 2022
kibanamachine pushed a commit that referenced this pull request Mar 21, 2022
@dimaanj
[Discover] Add documentation links for Document Explorer (#127971)
e2129da 
* [Discover] add document explorer docs links

* [Discover] fix tests

* [Discover] update translations

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit ee62fe8)
@kibanamachine kibanamachine mentioned this pull request Mar 21, 2022
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.1

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Mar 21, 2022
@kibanamachine @dimaanj
[Discover] Add documentation links for Document Explorer (#127971) (#…
e052109 
…128177)

* [Discover] add document explorer docs links

* [Discover] fix tests

* [Discover] update translations

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit ee62fe8)

Co-authored-by: Dmitry Tomashevich <39378793+Dmitriynj@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kertal kertal kertal approved these changes

@lcawl lcawl lcawl approved these changes

Assignees

@dimaanj dimaanj

Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.1.1 v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Discover] Add links to documentation for Document Explorer
7 participants
@dimaanj @elasticmachine @kibanamachine @kibana-ci @spalger @kertal @lcawl