[RAM] Feature flagging for triggers actions UI plugin

[JiaweiWu]

Summary

For the upcoming feature to add logs in the rules details page (#126624), we would like to take a more incremental approach when it comes to committing code and PRs. Therefore, this PR borrows the feature flagging work done by @Zacqary, in this PR: #124428 so we can start using feature flags in triggers actions UI.

usage:

for react components:

import { getIsExperimentalFeatureEnabled } from 'triggers_actions_ui/public/common/get_experimental_features';
...
const isEnabled = getIsExperimentalFeatureEnabled('rulesListDatagrid');

for server side:

enable configs in plugin:

export class TriggersActionsPlugin implements Plugin<void, PluginStartContract> {
  private readonly logger: Logger;
  private readonly data: PluginStartContract['data'];
  private config: ConfigType; <---

  constructor(ctx: PluginInitializerContext) {
    this.logger = ctx.logger.get();
    this.data = getService();
    this.config = createConfig(ctx); <--
  }

and then it'll be accessible via:

const experimentalFeatures = this.config.experimentalFeatures;

Co-authored-by: Zacqary Adam Xeper zacqary.xeper@elastic.co

[elasticmachine]

Pinging @elastic/response-ops (Team:ResponseOps)

[JiaweiWu]

@elasticmachine merge upstream

[JiaweiWu]

@elasticmachine merge upstream

[chrisronline]

Security Solution? :)

[chrisronline]

So this is where we set the list of experiment features in use?

[chrisronline]

How would these be used in the UI code exactly?

[JiaweiWu]

We set the experiments in the service file, or from kibana.dev.yml. This looks to be a default of sorts

@Zacqary just out of curiosity, Do you know the purpose of keeping these defaults as opposed to reading directly from the service? I'm not too sure what the use case would be.

[chrisronline]

we also maintain a list here too: https://github.com/elastic/kibana/pull/126957/files#diff-8e2ca70700895b17125532779945a1d0ab9076b4d4db304c065b47f82b6628a5R14

[JiaweiWu]

yea, if these defaults aren't required, I'll make this a util function that reads from the service as opposed to a hook

[XavierM]

looks at this example in Zac's PR ->

https://github.com/elastic/kibana/pull/124428/files#diff-84884bf338af7abf13071d432ccefb10ebc6c0513f1fa0492b42d66a79320953R49

[XavierM]

@elasticmachine merge upstream

[chrisronline]

LGTM!

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: 4145484
• Storybooks Preview
• Webpack Bundle Analyzer

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
triggersActionsUi	331	333	+2

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
triggersActionsUi	242	244	+2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
triggersActionsUi	700.1KB	700.1KB	+2.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
triggersActionsUi	57.3KB	58.2KB	+934.0B

Unknown metric groups

API count

id	before	after	diff
triggersActionsUi	254	256	+2

History

• 💔 Build #30676 failed 3859238
• 💔 Build #30547 failed c7b78a0
• 💚 Build #30167 succeeded 868bbf3
• 💔 Build #30149 failed dd97aa1
• 💔 Build #30060 failed 8f0201b

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[kibanamachine]

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 126957 or prevent reminders by adding the backport:skip label.

[kibanamachine]

⚪ Backport skipped

The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.

Manual backport

To create the backport manually run:

node scripts/backport --pr 126957

Questions ?

Please refer to the Backport tool documentation