[Stack Monitoring] More typescript conversion #126654
Conversation
8dcbab1 to
dce1d88
Compare
dce1d88 to
4f92d4d
Compare
Also changes some overly restrictive types that weren't accurate
cf22072 to
9479ad1
Compare
| @@ -5,7 +5,9 @@ | |||
| * 2.0. | |||
| */ | |||
|
|
|||
| export function monitoringBulk(Client, _config, components) { | |||
| // TODO: Track down where this function is called by the elasticsearch client setup so we can properly type these | |||
There was a problem hiding this comment.
Might be good to file this as a follow up issue so we don't lose track of it.
| start, | ||
| end, | ||
| }) | ||
| : []; |
There was a problem hiding this comment.
Interesting that [] doesn't match the return signature of getLogTypes but we can figure that out in future cleanup I'm sure. (I don't think this one needs a followup issue)
| @@ -17,6 +17,8 @@ import { LegacyRequest } from '../../types'; | |||
| * | |||
| * @param req {Object} the server route handler request object | |||
| */ | |||
|
|
|||
| // TODO: replace LegacyRequest with current request object + plugin retrieval | |||
There was a problem hiding this comment.
Might be good to open an issue for this too (and the other "replace LegacyRequest" todos). I think it's related to #109232 but I can't find a stack-monitoring-specific issue.
|
Oh, should we backport this to 8.0 & 8.1? Not sure what's generally expected there, but since it's more a fix than a feature it might be good to have it backported to help future backports simpler. |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
Good question. 8.1 is set to release next week so I think generally in cases like that, any new fixes for 8.0 or 8.1 will need to be patches which means they'd branch from that release branch and not come from main. So for that reason I'm not sure I would normally backport these to those. Still figuring out if make it minor means anything new here, though, so I'll think about it before merging. Thanks for flagging. |
|
8.1 isn't out yet so I added a v8.1.1 label just in case other fixes get scheduled for 8.1.1. Thanks! |
* Converts monitoring_bulk to TS * Converts routes/alerts to TS, closes elastic#117755 * Converts check_access route to TS * Converts clusters routes to TS Also changes some overly restrictive types that weren't accurate * Fixes lowercase method for legacy server route (cherry picked from commit 0bd7724)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
* Converts monitoring_bulk to TS * Converts routes/alerts to TS, closes #117755 * Converts check_access route to TS * Converts clusters routes to TS Also changes some overly restrictive types that weren't accurate * Fixes lowercase method for legacy server route (cherry picked from commit 0bd7724) Co-authored-by: Jason Rhodes <jason.rhodes@elastic.co>
Summary
More typescript conversion for #102436