-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ResponseOps] Adds uiSettingsClient
to alerting framework services
#126648
[ResponseOps] Adds uiSettingsClient
to alerting framework services
#126648
Conversation
Pinging @elastic/response-ops (Team:ResponseOps) |
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
2dff7ae
to
844b10b
Compare
💛 Build succeeded, but was flakyMetrics [docs]Public APIs missing comments
History
To update your PR or re-run it, just comment with: cc @dplumlee |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for adding this!
💔 Backport failedThe pull request could not be backported due to the following error: How to fixRe-run the backport manually:
Questions ?Please refer to the Backport tool documentation |
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Summary
Related to #64588 and brought up in this (much more recent) PR comment
Some of the plugins that use the alerting framework plugin (such as the security solution) require access to kibana's ui advanced settings on the backend. Previously this had been achieved by using the uiSettings config off the
savedObjectsClient
directly but as stated in the above comment, this is not a best practice approach as the location/format of the config is subject to change.This PR adds the
uiSettingsClient
from the kibanacore
start service and passes it down through to the alerting framework services which then allows it to be consumed and utilized by dependent features such as the security solution rule executors.Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers