Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Add functional tests for bundled packages #126595

Merged
merged 11 commits into from
Mar 2, 2022

Conversation

kpollich
Copy link
Member

@kpollich kpollich commented Mar 1, 2022

Summary

Closes #124254

Add functional tests for a few installation/update cases around bundled packages:

  • Baseline bundled installation behavior via API
  • Update from bundled package to newer bundled package via API
  • Update from bundled package to newer package from registry via API

Also includes some alterations to payloads coming from install APIs to include a _meta property with an install_source value. This allows us to easily assert on expected install sources in tests, but also provides likely valuable debugging information around these APIs.

Finally, this moves the bundled packages directory to fleet/target rather than a separate git ignored directory under fleet/server. This is consistent with other build artifacts, etc.

@kpollich kpollich added release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team auto-backport Deprecated - use backport:version if exact versions are needed v8.2.0 labels Mar 1, 2022
@kpollich kpollich requested review from a team as code owners March 1, 2022 14:18
@kpollich kpollich self-assigned this Mar 1, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small suggestion otherwise 🚀

@kpollich
Copy link
Member Author

kpollich commented Mar 1, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
fleet 1233 1235 +2
Unknown metric groups

API count

id before after diff
fleet 1350 1352 +2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kpollich

@kpollich kpollich merged commit 31261df into elastic:main Mar 2, 2022
@kpollich kpollich deleted the 124254-add-bundled-package-tests branch March 2, 2022 17:23
@kibanamachine
Copy link
Contributor

💔 Backport failed

The pull request could not be backported due to the following error:
There are no branches to backport to. Aborting.

How to fix

Re-run the backport manually:

node scripts/backport --pr 126595

Questions ?

Please refer to the Backport tool documentation

@kpollich kpollich added the backport:skip This commit does not require backporting label Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fleet] Add functional/integration tests around bundled packages
6 participants