[Lens] disable auto apply toggle flag strategy

[drewdaemon]

Summary

Counterpart to #125158.

In this approach, we mark whether changes should be applied by way of a boolean flag in the state.

In some ways, this is simple, but when we want the app to start with auto-apply turned off, the workspace panel has to ignore the setting until the initial render is finished which is a little tricky. Applying changes is also done by way of toggling the setting on and off. This sometimes makes the switch flash a bit.

[drewdaemon]

Is this a little hacky?

[dej611]

Perhaps this may incur into race conditions. But the point is still valid, having a nextFrame function would be really useful here and also elsewhere

[drewdaemon]

This is the boolean flag we add to the state.

[mbondyra]

Do I understand this correctly that in this approach we wouldn't be able to have a potential discard button because the last applied state is not stored anywhere? Not sure if we're planning on having it, just thinking about it based on Visualize design.

[drewdaemon]

Thanks @dej611 and @mbondyra. Great points both here and in Slack.

I think it has become clear that the other approach is best because of the capabilities it affords

• Easy to check if the user has applied their changes—allows us to provide a better UX
• Discard button
• Option to expand into more advanced functionality such as saving drafts, etc

It also feels less "tricky." I'll move forward with the other approach knowing we've chosen the right path.

[kibana-ci]

💔 Build Failed

• Buildkite Build
• Commit: d75141e
• Interpreting CI Failures
• Storybooks Preview
• Webpack Bundle Analyzer

Failed CI Steps

• Default CI Group #3
• Default CI Group #3
• Default CI Group #4
• Default CI Group #4
• Jest Tests #1
• Checks

Test Failures

• [job] [logs] Jest Tests #1 / Initializing the store should initialize all datasources with state from doc
• [job] [logs] Default CI Group #3 / lens app lens smokescreen tests should handle edge cases in reference-based operations
• [job] [logs] Default CI Group #3 / lens app lens smokescreen tests should handle edge cases in reference-based operations
• [job] [logs] Default CI Group #4 / lens app time shift should show an error if terms is used and provide a fix action
• [job] [logs] Default CI Group #4 / lens app time shift should show an error if terms is used and provide a fix action
• [job] [logs] Jest Tests #1 / workspace_panel should show an error message if the expression fails to parse
• [job] [logs] Jest Tests #1 / workspace_panel should show an error message if there are missing indexpatterns in the visualization
• [job] [logs] Jest Tests #1 / workspace_panel should show an error message if validation on both datasource and visualization do not pass
• [job] [logs] Jest Tests #1 / workspace_panel should show an error message if validation on datasource does not pass
• [job] [logs] Jest Tests #1 / workspace_panel should show an error message if validation on visualization does not pass

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
lens	748	750	+2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
lens	1.1MB	1.1MB	+4.9KB

Unknown metric groups

ESLint disabled in files

id	before	after	diff
apm	15	14	-1
securitySolution	66	65	-1
uptime	7	6	-1
total			-3

ESLint disabled line counts

id	before	after	diff
apm	85	82	-3
uptime	48	42	-6
total			-9

References to deprecated APIs

id	before	after	diff
canvas	70	64	-6
fleet	5	4	-1
lens	237	185	-52
monitoring	40	28	-12
stackAlerts	183	157	-26
upgradeAssistant	8	3	-5
total			-102

Total ESLint disabled count

id	before	after	diff
apm	100	96	-4
securitySolution	513	512	-1
uptime	55	48	-7
total			-12

History

• 💔 Build #26271 failed d75141e
• 💔 Build #22977 failed 8e15e08
• 💔 Build #22974 failed 72d3fbddf687e1adcf64ff221a5a807fec87c12a

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream