-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove deps on data plugin #124682
Closed
afharo
wants to merge
21
commits into
elastic:main
from
afharo:use-status-service-to-wait-for-artifacts-installations
Closed
remove deps on data plugin #124682
afharo
wants to merge
21
commits into
elastic:main
from
afharo:use-status-service-to-wait-for-artifacts-installations
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ice-to-wait-for-artifacts-installations
@elasticmachine merge upstream |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
💔 Build FailedFailed CI Steps
Test Failures
Metrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:skip
This commit does not require backporting
release_note:skip
Skip the PR/issue when compiling release notes
v8.2.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As detailed in #123720, some tests began to fail when the
data
plugin addssecurity
as an optional dependency (#121955). All the failures are caused by timeouts.As we troubleshot the timeouts, we found out that running the server first (
node scripts/functional_tests_server
) and the tests separately (node scripts/functional_test_runner
) wouldn't make it fail. Also, adding 90s wait for the cluster to stabilise after start also turned the CI green. So we focused on any issues with running the tests as soon as Kibana became available (GREEN).Looking at the logs, we can see that ES is busy installing templates when the tests are running. This makes us believe that the issue is that the tests start too soon after this change.
Here's an example of a successful PR:

Compared to the failure:


Bear in mind the line
warn debug logs are being captured, only error logs will be written to the console
right before the tests. Looking at the captured.log
file, we can see the component templates are installed during the execution of the test.To ensure that the tests are installed only after all the artifacts are properly set up, this PR uses the status API to explicitly declare the initializing status of the relevant plugins. The relevant commit for this change is
4081b6b
(#124682).👆 The change above fixed the broken tests for the Security HTTP API.
However, the UI tests were still an issue. It looks like those failures are caused by the changes in the
custom_integrations
. I reverted the changes and, to stop the circular dependencies CI check, I changedpresentation_util
'skibana.json
. However, the circular dependency still exists in the requiredBundles and should be fixed.Risk Matrix
For maintainers