Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(NA): splits types from code on @kbn/test #124469

Merged
merged 10 commits into from
Feb 4, 2022
Merged

chore(NA): splits types from code on @kbn/test #124469

merged 10 commits into from
Feb 4, 2022

Conversation

mistic
Copy link
Member

@mistic mistic commented Feb 3, 2022

This PR is a step forward on #104519

It splits the the types build from the code transpilation.

@mistic mistic added chore Team:Operations Team label for Operations Team release_note:skip Skip the PR/issue when compiling release notes v8.2.0 labels Feb 3, 2022
@mistic mistic requested a review from jbudz February 3, 2022 00:01
@mistic mistic marked this pull request as ready for review February 3, 2022 15:48
@mistic mistic requested a review from a team February 3, 2022 15:48
@mistic mistic requested review from a team as code owners February 3, 2022 15:48
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@mistic mistic requested review from a team as code owners February 3, 2022 15:48
@mistic mistic requested review from a team as code owners February 3, 2022 15:48
@mistic
Copy link
Member Author

mistic commented Feb 3, 2022

@elasticmachine merge upstream

@botelastic botelastic bot added Feature:Embedding Embedding content via iFrame Team:Fleet Team label for Observability Data Collection Fleet team labels Feb 3, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

scottybollinger
scottybollinger approved these changes Feb 3, 2022
View reviewed changes
Copy link
Contributor

@scottybollinger scottybollinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enterprise Search changes LGTM

YulNaumenko
YulNaumenko approved these changes Feb 3, 2022
View reviewed changes
Copy link
Contributor

@YulNaumenko YulNaumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security Threat Hunting changes LGTM!

@mistic

This comment was marked as outdated.

Sign in to view
@mistic
Copy link
Member Author

mistic commented Feb 3, 2022

@elasticmachine run elasticsearch-ci/docs

nchaulet
nchaulet approved these changes Feb 3, 2022
View reviewed changes
Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fleet changes LGTM!

@mistic
Copy link
Member Author

mistic commented Feb 3, 2022

@elasticmachine merge upstream

jportner
jportner approved these changes Feb 3, 2022
View reviewed changes
Copy link
Contributor

@jportner jportner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Platform security test changes LGTM

jbudz
jbudz approved these changes Feb 3, 2022
View reviewed changes
Copy link
Member

@jbudz jbudz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windows LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/test-jest-helpers - 101 +101

Any counts in public APIs

Total count of every any typed public API. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats any for more detailed information.

id before after diff
@kbn/test-jest-helpers - 8 +8

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
@kbn/test-jest-helpers - 2 +2
kibana 930 936 +6
total +8
Unknown metric groups

API count

id before after diff
@kbn/test-jest-helpers - 128 +128

ESLint disabled line counts

id before after diff
@kbn/test-jest-helpers - 6 +6
esUiShared 12 11 -1
total +5

Total ESLint disabled count

id before after diff
@kbn/test-jest-helpers - 6 +6
esUiShared 12 11 -1
total +5

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

alisonelizabeth
alisonelizabeth approved these changes Feb 3, 2022
View reviewed changes
Copy link
Contributor

@alisonelizabeth alisonelizabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

platform deployment management changes LGTM

@mistic
Copy link
Member Author

mistic commented Feb 4, 2022

This PR is mainly changing the layout of the @kbn/test package and separates the jest helpers into a new package so we can consume its types on the project avoiding the clashes with mocha. I'm going ahead on merging that PR. Let me know if you have further feedback.

@mistic mistic merged commit a5b4b82 into elastic:main Feb 4, 2022
@mistic mistic removed Feature:Embedding Embedding content via iFrame Team:Fleet Team label for Observability Data Collection Fleet team labels Feb 4, 2022
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 8, 2022
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 124469 or prevent reminders by adding the backport:skip label.

1 similar comment
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 124469 or prevent reminders by adding the backport:skip label.

@mistic mistic added the backport:skip This commit does not require backporting label Feb 9, 2022
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nchaulet nchaulet nchaulet approved these changes

@scottybollinger scottybollinger scottybollinger approved these changes

@jbudz jbudz jbudz approved these changes

@alisonelizabeth alisonelizabeth alisonelizabeth approved these changes

@jportner jportner jportner approved these changes

@YulNaumenko YulNaumenko YulNaumenko approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting chore release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@mistic @elasticmachine @kibana-ci @kibanamachine @nchaulet @scottybollinger @jbudz @alisonelizabeth @jportner @YulNaumenko