Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.17] Vega functional tests fail when run against ES 8.0 #123134

Merged
merged 5 commits into from
Jan 17, 2022
Merged

[7.17] Vega functional tests fail when run against ES 8.0 #123134

merged 5 commits into from
Jan 17, 2022

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Jan 17, 2022 •
edited
Loading

Closes: #123081

Summary

This PR is a backport of #109090 , #112781, #115001

Reason for backporting:

When testing 7.17 Kibana against 8.0 Elasticsearch, we get some Vega-related failures from CI:

OSS CI Group #11 / visualize app visualize ciGroup11 vega chart in visualize app vega chart initial render should have view and control containers
OSS CI Group #11 / visualize app visualize ciGroup11 vega chart in visualize app vega chart initial render should have view and control containers

https://buildkite.com/elastic/kibana-7-dot-latest-es-8-dot-0-forward-compatibility/builds/15

In 7.17, basic Kibana functions are still expected to work when run against ES 8.0, because during an upgrade process users will upgrade ES first. So we need to identify any failures from these builds and determine if they are simply bugs in our tests, or legit issues that would be 7.17 blockers.

alexwizp and others added 3 commits January 17, 2022 13:47
@alexwizp @kibanamachine @VladLasitsa
[vega] Handle removal of deprecated date histogram interval (elastic#…
f1a6f96 
…109090)

* [vega] Handle removal of deprecated date histogram interval

Fixes: elastic#106352

* fix CI

* add deprecation_interval_info

* add test

* Update vega_info_message.tsx

* fix types

* Update es_query_parser.ts

* apply comments

* fix error

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Uladzislau Lasitsa <vlad.lasitsa@gmail.com>
@stratoula @KOTungseth
@kibanamachine @alexwizp
Updates the VEGA docs for v8.0 (elastic#112781)
483b9f2 
* Update VEGA docs for v8.0

* Update docs/user/dashboard/vega-reference.asciidoc

Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>

Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@alexwizp
[Vega] Replacing the 'interval' property should only happen for the d…
5a1a918 
…ate_histogram aggregation (elastic#115001)
@alexwizp alexwizp added v7.17.0 Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Vega Vega visualizations release_note:fix labels Jan 17, 2022
@alexwizp alexwizp self-assigned this Jan 17, 2022
@flash1293
Copy link
Contributor

This is not a fix as the interval param works fine in released versions and they were never expected to be compatible to ES 8.0 (only Kibana 7.17 is)

@flash1293 flash1293 added release_note:skip Skip the PR/issue when compiling release notes and removed release_note:fix labels Jan 17, 2022
@alexwizp
Copy link
Contributor Author

@elasticmachine merge upstream

@flash1293
Copy link
Contributor

@elasticmachine merge upstream

@flash1293 flash1293 marked this pull request as ready for review January 17, 2022 17:09
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@flash1293
Copy link
Contributor

Tested and vega requests are re-written correctly to only use fixed_interval and calendar_interval. This looks good to merge once it gets green CI

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
visTypeVega 239 241 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visTypeVega 1.9MB 1.9MB +137.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 454.8KB 455.0KB +186.0B
visTypeVega 36.0KB 37.2KB +1.2KB
total +1.3KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @alexwizp

@alexwizp alexwizp changed the title Vega functional tests fail when run against ES 8.0 [7.17] Vega functional tests fail when run against ES 8.0 Jan 17, 2022
@alexwizp alexwizp merged commit dcd6a81 into elastic:7.17 Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flash1293 flash1293 flash1293 approved these changes

@stratoula stratoula Awaiting requested review from stratoula

Assignees

@alexwizp alexwizp

Labels
Feature:Vega Vega visualizations release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.17.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@alexwizp @flash1293 @elasticmachine @kibana-ci @stratoula @kibanamachine