[Controls] Update empty state

[andreadelrio]

Summary

• Added custom illustration provided by visual design team
• Fix toolbar buttons layout in mobile

Checklist

Delete any items that are not applicable to this PR.

• Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
• Documentation was added for features that require explanation or tutorials
• Unit or functional tests were updated or added to match the most common scenarios
• Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
• Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
• If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
• This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
• This was checked for cross-browser compatibility

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk	Probability	Severity	Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space.	Low	High	Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks.	High	Low	Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled.	Medium	High	Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

• This was checked for breaking API changes and was labeled appropriately

[mdefazio]

This looks awesome.

Not a blocker, but does it make sense to add in an icon to the 'Add control' button. We have them on all the other buttons in this view and will frequently (?) include it on Create/Add buttons. Again, just a thought—not sure if it's necessary.

[ThomThomson]

Changes look great from a presentation team standpoint!

@mdefazio, using an icon on the create control button is a great idea, especially with the addition of the controls shortcut button on the toolbar which @Heenawter is going to add. If the same icon is used for both buttons, it could help to tie them together, because they will have the same behaviour. We could potentially use the controlsVertical or controlsHorizontal EUI icons to represent the idea of controls as a whole / a generic control.

P.S. the CI failure is due to one of the dashboard screenshot tests - but it doesn't look like your toolbar changes caused it because the dashboard isn't even in edit mode when the screenshot is taken... very strange

[andreadelrio]

@elasticmachine merge upstream

[ThomThomson]

It looks like the CI failure is actually legitimate, as there is a definite layout shift when flipping back and forth between Main (in blue) and this branch (in pink) in view mode. I am pretty sure it's due to the 4 pixels of padding-bottom which was added to .dshDashboardViewport-controlGroup in this PR. To fix it, we could either move that padding to a different element, or we could ensure that the div with that doesn't show up at all unless the controls are enabled and the dashboard is in edit mode.

[andreadelrio]

@elasticmachine merge upstream

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: fcb4015
• Storybooks Preview

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
controls	129	133	+4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
controls	115.6KB	379.6KB	⚠️ +263.9KB
dashboard	273.1KB	273.3KB	+185.0B
total			+264.1KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
presentationUtil	42.8KB	42.9KB	+121.0B

History

• 💔 Build #17327 failed 30e1e9c
• 💔 Build #17086 failed 2495cd8
• 💔 Build #16764 failed cc9cf56
• 💔 Build #16611 failed 3058191

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream