[Security Solution][Investigations] Fix incorrect height of alert table #122542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was an issue where when going from a full page to a page with only one item, the height of the table was not tall enough. That meant the single row was hidden.
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
💚 Build Succeeded
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: cc @janmonschke |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There was an issue where when going from a full page to a page with only one item, the height of the table was not tall enough. That meant the single row was hidden. (#122111)
I tried out several ways to prevent this issue but most of them were rather brittle. In the end I decided to add an extra row's height to the hacked height when the actual data is less than the page size.
Keep in mind that the module that contains the change is likely to be retired in 8.1. That version will contain a new version of EUI data grid which makes the height hack obsolete. (#122386)
Screen.Recording.2022-01-10.at.14.47.55.mov