Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cluster name to EP/Lists telemetry #122429

Merged
merged 7 commits into from
Jan 10, 2022

Conversation

pjhampton
Copy link
Contributor

Summary

Adds cluster and license info to endpoint and lists telemetry documents for customer enrichment pipeline.

  • Makes a call to the cluster once a day (~24hrs) and annotates the telemetry documents with cluster/license info
  • Does this work every run (rather than pass in as a param) because I can't guarantee that a new task isn't spawned from an upgraded cluster
  • Sends cluster name in HTTP header

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@pjhampton pjhampton added Feature:Telemetry v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. auto-backport Deprecated - use backport:version if exact versions are needed v8.1.0 labels Jan 6, 2022
@pjhampton pjhampton self-assigned this Jan 6, 2022
@pjhampton pjhampton requested a review from a team as a code owner January 6, 2022 13:10
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@pjhampton pjhampton changed the title Add cluster number to EP/Lists telemetry Add cluster name to EP/Lists telemetry Jan 6, 2022
Copy link
Contributor

@donaherc donaherc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome -- thanks for building this out!

@@ -49,9 +47,6 @@ export const createMockTelemetryReceiver = (
} as unknown as jest.Mocked<TelemetryReceiver>;
};

/**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, superfluous, good to remove

@pjhampton
Copy link
Contributor Author

@elasticmachine merge upstream

@pjhampton
Copy link
Contributor Author

I'm happy with this. I have generated some example docs to aid with the enrichments.

@pjhampton pjhampton enabled auto-merge (squash) January 10, 2022 13:03
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @pjhampton

@pjhampton pjhampton merged commit 5254cb5 into main Jan 10, 2022
@pjhampton pjhampton deleted the pjhampton/add-cluster-number-to-security-telemetry branch January 10, 2022 13:40
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 10, 2022
* Send additional http header with cluster name included for join.

* Add cluster / license info to ep document.

* Add cluster / license info to lists document.

* Fix tests.

* Be explicit with type imports.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 5254cb5)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.0

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jan 10, 2022
* Send additional http header with cluster name included for join.

* Add cluster / license info to ep document.

* Add cluster / license info to lists document.

* Fix tests.

* Be explicit with type imports.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 5254cb5)

Co-authored-by: Pete Hampton <pjhampton@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Telemetry release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.0.0 v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants