Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integration test for Fleet setup with HA kibana deployment #122349

Merged
merged 2 commits into from
Feb 4, 2022
Merged

Add integration test for Fleet setup with HA kibana deployment #122349

merged 2 commits into from
Feb 4, 2022

Conversation

joshdover
Copy link
Contributor

@joshdover joshdover commented Jan 5, 2022 •
edited
Loading

Summary

Closes #118423

This adds a jest_integration test that will start multiple Kibana instances in parallel with the same preconfigured agent policies and outputs and verify that no duplicates are created.

@joshdover
Copy link
Contributor Author

@kpollich I was able to get this working. I think the issue you were having was that your test wasn't doing anything except expect(true).toEqual(true) which was causing Kibana to be shut down before any logs were actually emitted.

@nchaulet nchaulet mentioned this pull request Jan 10, 2022
Merged
@joshdover joshdover self-assigned this Feb 4, 2022
@joshdover joshdover added auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.1.0 v8.2.0 labels Feb 4, 2022
@joshdover joshdover marked this pull request as ready for review February 4, 2022 14:07
@joshdover joshdover requested a review from a team as a code owner February 4, 2022 14:07
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@joshdover joshdover requested a review from nchaulet February 4, 2022 15:47
nchaulet
nchaulet approved these changes Feb 4, 2022
View reviewed changes
Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

  • 💚 Build #15930 succeeded 308156b1c013f3995ffd47145a2aecd958805f79

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @joshdover

@joshdover joshdover merged commit ce8efdf into elastic:main Feb 4, 2022
@joshdover joshdover deleted the test-ha-fleet branch February 4, 2022 17:29
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 4, 2022
@joshdover @kibanamachine
Add integration test for Fleet setup with HA kibana deployment (elast…
b0ade59 
…ic#122349)

(cherry picked from commit ce8efdf)
@kibanamachine kibanamachine mentioned this pull request Feb 4, 2022
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.1

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Feb 7, 2022
@kibanamachine @joshdover
Add integration test for Fleet setup with HA kibana deployment (#122349…
09b8e40 
…) (#124725)

(cherry picked from commit ce8efdf)

Co-authored-by: Josh Dover <1813008+joshdover@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nchaulet nchaulet nchaulet approved these changes

Assignees

@joshdover joshdover

Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.1.0 v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Fleet] Fix Fleet Setup to handle concurrent calls across nodes in HA Kibana deployment
5 participants
@joshdover @elasticmachine @kibana-ci @kibanamachine @nchaulet