-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Reporting] Reporting info panel touch ups #120617
Merged
jloleysens
merged 22 commits into
elastic:main
from
jloleysens:reporting/info-panel-touch-ups
Dec 15, 2021
Merged
Changes from 20 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
223af50
changed info -> summary and combined maximum attempts and attempts field
jloleysens 305059f
added spaceId if it is there to job info
jloleysens bfb8036
moved space id to job details section
jloleysens 318f8e1
moved processing and job info into a single array
jloleysens d828732
wip, introduced a new structure to the flyout for easier visual parsi…
jloleysens 586e43f
remove unnecessary div
jloleysens 1c0062e
added warnings and errors to callout and cleaned up comments
jloleysens 0ffd3fc
remove unused functionality and introduce date formatting per advance…
jloleysens 28fb5c0
remove unused import
jloleysens c67b758
remove unused i18n
jloleysens c2e4e74
Merge branch 'main' into reporting/info-panel-touch-ups
kibanamachine 4d14d9f
Merge branch 'main' into reporting/info-panel-touch-ups
kibanamachine 09707a8
refactor check for info.max_attempts in flyout content
jloleysens b3d1ead
update info.lyout.dimensions.height to be Math.ceiled
jloleysens 009b5fb
update info.lyout.dimensions.width to be Math.ceiled
jloleysens f4d1166
Merge branch 'main' into reporting/info-panel-touch-ups
kibanamachine c6e3942
lint and remove bad suggestion commit
jloleysens 614c723
added actions button to flyout, in flyout footer
jloleysens b218605
create a little bit more breathing room for the section titles
jloleysens 0612c02
added logic to disable the action buttons in the flyout when the acti…
jloleysens d94957d
update copy per feedback
jloleysens 72346b7
added basic tests for the actions menu in the flyout
jloleysens File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really have the context for this text, but can it be: Open in Kibana
If you do include app, it should be lower case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Open in Kibana" sounds good!