[Security Solution] endpoint metadata transform stats API #120429
Conversation
938067d to
e1de52a
Compare
| @@ -114,54 +118,52 @@ describe('test endpoint routes', () => { | |||
| perPage: 1000, | |||
| }); | |||
| }); | |||
|
|
|||
| endpointAppContextService = new EndpointAppContextService(); | |||
There was a problem hiding this comment.
no changes to this chunk of code, just moving this up one level to remove the duplicates.
| const t = transform as unknown as { id: string }; | ||
| return client.transform.startTransform({ transform_id: t.id }); | ||
| }); | ||
| return Promise.all( |
There was a problem hiding this comment.
hard to believe everything was passing consistently without this 😅 .
|
Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt) |
| @@ -784,7 +784,7 @@ export async function handleLoadMetadataTransformStats(http: HttpStart, store: E | |||
|
|
|||
| try { | |||
| const transformStatsResponse: TransformStatsResponse = await http.get( | |||
| METADATA_TRANSFORM_STATS_URL | |||
| METADATA_TRANSFORMS_STATUS_ROUTE | |||
There was a problem hiding this comment.
Do you know what happens if the API call returns a failure in the code below (line 795)? Do we show it on the UI?
There was a problem hiding this comment.
It shouldn't show up in the UI. the banner only shows if the response has transforms with the warning states we defined. so no transforms returned would just be silently ignored as far as the user is concerned. though this should be exceedingly rare for permission based failures since the banner lives in the endpoint list component which uses the same permissions.
e1de52a to
aadd7cb
Compare
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
💔 Backport failed
To backport manually run: |
…0429) # Conflicts: # x-pack/plugins/security_solution/public/management/pages/endpoint_hosts/store/middleware.ts
Summary
Add new endpoint metadata transform stats API that explicitly checks for fleet permissions and switch endpoints transform warning banner to use new endpoint.
Checklist
For maintainers