Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI Framework] Add support for multi-line queries to LocalNavSearch component of UI Framework. #11975

Closed
wants to merge 1 commit into from
Closed

[UI Framework] Add support for multi-line queries to LocalNavSearch component of UI Framework. #11975

wants to merge 1 commit into from

Conversation

cjcenizal
Copy link
Contributor

@cjcenizal cjcenizal commented May 23, 2017 •
edited
Loading

This code was cherry-picked from #11972.

image

One thing to consider is how this will interact with autocompletion suggestions, similar to what we encountered in Discover as part of #10928:

screen shot 2017-04-12 at 1 00 10 pm

@cjcenizal cjcenizal added Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. :Discovery release_note:enhancement labels May 23, 2017
@cjcenizal
Copy link
Contributor Author

CC @weltenwort @lukasolson @Bargs

@cjcenizal cjcenizal force-pushed the feature/expandable-local-nav-search branch from c872ab5 to 9237e9e Compare May 23, 2017 17:40
@Bargs
Copy link
Contributor

Bargs commented May 23, 2017

CC @tbragin too

As it's implemented now, how does it interact with the existing typeahead dropdown?

Though when I said autocomplete, I was actually talking about this possible future state

@cjcenizal cjcenizal mentioned this pull request May 24, 2017
Merged
@alexfrancoeur
Copy link

@cjcenizal is this the PR to follow for your phase 2 of #11972?

@Bargs current behavior can be seen below.
may-26-2017 16-33-00

I'd almost expect something similar for this PR. Eventually it'd be nice to have the UX that you referenced or something more along the lines of console.

@cjcenizal
Copy link
Contributor Author

@alexfrancoeur This PR is similar and the code originated in the Timelion PR, but for now I'm considering it a separate feature until we decide to move the Timelion input back into the LocalNav.

@alexfrancoeur
Copy link

@cjcenizal sounds good, please just tag me in the new PR for the additional UI enhancements.

weltenwort
weltenwort reviewed May 31, 2017
View reviewed changes
ui_framework/doc_site/src/views/local_nav/local_nav_search_multi_line.js
@@ -0,0 +1,68 @@
/* eslint-disable */

const $searchInput = $('#expandableSearchInput');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we want to provide the examples using React components?

@cjcenizal
Copy link
Contributor Author

cjcenizal commented Jun 28, 2017 •
edited
Loading

This is on hold until we've figured out how it will interact with KQL (#12282).

@Bargs
Copy link
Contributor

Bargs commented Aug 4, 2017

BTW @cjcenizal this is on my todo list to play with. Some of the geo queries can get quite large in Kuery so we'll definitely want multi line support. Not sure how soon I'll get to it, but it's on my mind :)

@cjcenizal
Copy link
Contributor Author

Closing this for now.

@cjcenizal cjcenizal closed this Oct 25, 2017
@cjcenizal cjcenizal deleted the feature/expandable-local-nav-search branch July 6, 2018 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weltenwort weltenwort weltenwort left review comments

Assignees
No one assigned
Labels
release_note:enhancement stalled Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cjcenizal @Bargs @alexfrancoeur @weltenwort @lukasolson