[Fleet] Override branch in doc links #119514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/fleet (Team:Fleet) |
jen-huang
previously approved these changes
Nov 23, 2021
jen-huang
reviewed
Nov 23, 2021
src/plugins/custom_integrations/server/language_clients/index.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Jen Huang <its.jenetic@gmail.com>
jen-huang
approved these changes
Nov 23, 2021
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 24, 2021
Co-authored-by: Jen Huang <its.jenetic@gmail.com>
kibanamachine
added a commit
that referenced
this pull request
Nov 24, 2021
dmlemeshko
pushed a commit
that referenced
this pull request
Nov 29, 2021
Co-authored-by: Jen Huang <its.jenetic@gmail.com>
TinLe
pushed a commit
to TinLe/kibana
that referenced
this pull request
Dec 22, 2021
Co-authored-by: Jen Huang <its.jenetic@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The documentation links in the language client integrations get a 404 (e.g. when you click any of the clients here):
This is occurring because those links do not use the Kibana doc link service (per
#113666 (comment) and #95389) and therefore don't have our current work-around for the lack of "main" branch documentation.
This PR therefore just overrides the branch in https://github.com/elastic/kibana/blob/main/src/plugins/custom_integrations/server/language_clients/index.ts until we replace the "master" documentation with "main".