[Enterprise Search] Error on version mismatches #119101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bd93957 to
6dfb918
Compare
6dfb918 to
54fd1ae
Compare
richkuz
approved these changes
Nov 19, 2021
| @@ -68,6 +68,8 @@ export const callEnterpriseSearchConfigAPI = async ({ | |||
| warnMismatchedVersions(data?.version?.number, log); | |||
|
|
|||
| return { | |||
| enterpriseSearchVersion: data?.version?.number, | |||
| kibanaVersion: kibanaPackageJson.version, | |||
There was a problem hiding this comment.
Minor optional nit, feel free to ignore: warnMismatchedVersions above could be modified to take a kibanaVersion, so it doesn't have to know to look at kibanaPackageJson.version itself.
scottybollinger
approved these changes
Nov 19, 2021
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Test Failures
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 22, 2021
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Nov 22, 2021
dmlemeshko
pushed a commit
that referenced
this pull request
Nov 29, 2021
TinLe
pushed a commit
to TinLe/kibana
that referenced
this pull request
Dec 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR changes the Enterprise Search plugin to show an error message if the Kibana and Enterprise Search major and minor versions do not match.
When testing this, be sure to test entering the plugin via the Enterprise Search, App Search, and Workplace Search links. It's also worthwhile to try deep linking into the product as well. In all cases, a user should be presented the error message and prevented from using the plugin.
Checklist
Delete any items that are not applicable to this PR.
For maintainers