Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.0][RAC] 117686 replace alert workflow status in alerts view #118723
[8.0][RAC] 117686 replace alert workflow status in alerts view #118723
Changes from 26 commits
69091b4
38f1829
f4cb043
7880781
b17d8db
ec3be8c
391945b
3918b8d
2fb0b01
b4f8df4
80132a3
9b8ef26
67bf04d
1b82d80
edca181
338da2d
b1562d6
3e6c8c6
caab870
3ae465d
f79bcff
762ba4d
963b34e
3ade606
1682878
5b55600
8c8f114
2a0774f
6ebbb68
029bbea
8ada6ae
01caf34
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fkanout We should delete
workflowStatus
from here. There are probably a few more places that workflowStatus might need to be deleted as well. This is not needed, since we are not filtering by workflowStatus anymore in the UI. That's why we still seeworkflowStatus:open
in the urlbar when we first load the page. This is not needed anymoreThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as here:
#118723 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing
workflowStatus
It will blocked byTGridStandaloneCompProps
requiresfilterStatus
. Because the value offilterStatus
isworkflowStatus
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fkanout filterStatus at the moment has value
workflowStatus
, but nothing prevents us by changing it back to alert status. This change was introduced as part of this PR #109817, so we could pair together to manually revert some workflows status leftover that is not neededLet's get this PR merged for now. I summarized later on in a comment what we discussed during our sync up.