Improve Visualize sidebar accessibility. #11754
Conversation
|
jenkins, test this |
|
hmm, CI seems to be on the fritz.. jenkins, test this |
There was a problem hiding this comment.
thx!
some small questions/comments.
I can't really tell when tabbing when I'm over the 'Play' and 'x'-buttons. Is this something that this PR should address as well, or is this a separate styling issue? fwiw, the orange outline makes it easy to see where you are tabbing. For example, here it is used on the expand-buttons.
Perhaps we can have something similar for play-and-x?
Tabbing over the play and x-buttons does not work when they are grayed-out. Is that supposed to be the case?
|
Thanks @thomasneirynck this is a really good point. We're going to improve visual states in a separate PRs. If you're interested, this is the issue that captures this phase of work: #11517. CC @snide something to think about since you're working on the visual side of things right now. |
* Make Visualize sidebar tabs keyboard accssible. * Make Visualize Heatmap sidebar options keyboard accessible. * Remove unnecessary kbn-accessible-click from Visualize reset button. * Make Visualize Point Series sidebar options keyboard accessible.
* Make Visualize sidebar tabs keyboard accssible. * Make Visualize Heatmap sidebar options keyboard accessible. * Remove unnecessary kbn-accessible-click from Visualize reset button. * Make Visualize Point Series sidebar options keyboard accessible.
* Make Visualize sidebar tabs keyboard accssible. * Make Visualize Heatmap sidebar options keyboard accessible. * Remove unnecessary kbn-accessible-click from Visualize reset button. * Make Visualize Point Series sidebar options keyboard accessible.
* Make Visualize sidebar tabs keyboard accssible. * Make Visualize Heatmap sidebar options keyboard accessible. * Remove unnecessary kbn-accessible-click from Visualize reset button. * Make Visualize Point Series sidebar options keyboard accessible.
Addresses #11539