Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tutorial-load-dataset.asciidoc #11703

Merged
merged 6 commits into from
May 12, 2017
Merged

Update tutorial-load-dataset.asciidoc #11703

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2fb2710
Update tutorial-load-dataset.asciidoc
bhavyarm May 10, 2017
e909b14
Update tutorial-load-dataset.asciidoc
bhavyarm May 10, 2017
4e53f8d
Adding Deb's comments
bhavyarm May 11, 2017
d86cc6f
Changing js back to shell
bhavyarm May 11, 2017
9bdeee4
Changing the table
bhavyarm May 11, 2017
b9192ed
reversing two new lines and changing table's sh back to shell
bhavyarm May 11, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions docs/getting-started/tutorial-load-dataset.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,8 @@ curl -H 'Content-Type: application/json' -XPUT http://localhost:9200/shakespeare
"mappings" : {
"_default_" : {
"properties" : {
"speaker" : {"type": "string", "index" : "not_analyzed" },
"play_name" : {"type": "string", "index" : "not_analyzed" },
"speaker" : {"type": "keyword" },
"play_name" : {"type": "keyword" },
"line_id" : { "type" : "integer" },
"speech_number" : { "type" : "integer" }
}
Expand All @@ -78,7 +78,7 @@ curl -H 'Content-Type: application/json' -XPUT http://localhost:9200/shakespeare

This mapping specifies the following qualities for the data set:

* The _speaker_ field is a string that isn't analyzed. The string in this field is treated as a single unit, even if
* The _speaker_ field is a field that isn't analyzed. The text in this field is treated as a single unit, even if
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'd flip this around and say, Because the speaker and play_name fields are keyword fields, they are not analyzed. The strings are treated as a single unit even if they contain multiple words." and drop "The same applies to the play_name field."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense to me.

there are multiple words in the field.
* The same applies to the _play_name_ field.
* The _line_id_ and _speech_number_ fields are integers.
Expand Down