[console] Properly check for existence of deprecated console configs #11670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this a regression? If not, I think we should mark this as a breaking change just so people are aware. Since it's very clearly a bug without a workaround, we should still release this in 5.x, but probably only in 5.5. Thoughts? |
|
It's a regression from 5.3. It should be backwards compatible friendly when fixed, it will pull console's proxy config if it's configured and if not it will use the elasticsearch.ssl configuration. |
|
If it's a regression, then we fix it in 5.4.1 for sure. |
spalger
reviewed
May 9, 2017
| @@ -85,7 +85,7 @@ export default function (kibana) { | |||
| const whitelist = config.get('elasticsearch.requestHeadersWhitelist'); | |||
| const headers = filterHeaders(req.headers, whitelist); | |||
|
|
|||
| if (config.has('console.proxyConfig')) { | |||
| if (!isEmpty(config.get('console.proxyConfig'))) { | |||
There was a problem hiding this comment.
Ugh, we should rename config.has() to config.hasSchema().
tylersmalley
approved these changes
May 10, 2017
jbudz
added a commit
to jbudz/kibana
that referenced
this pull request
May 10, 2017
jbudz
added a commit
to jbudz/kibana
that referenced
this pull request
May 10, 2017
jbudz
added a commit
that referenced
this pull request
May 10, 2017
jbudz
added a commit
that referenced
this pull request
May 10, 2017
snide
pushed a commit
to snide/kibana
that referenced
this pull request
May 30, 2017
This was referenced Jun 19, 2019
|
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when checking whether to use the deprecated console proxy config we check if the schema exists, which will always return true. This causes the proxy config to always be used instead of falling back to the elasticsearch.ssl configuration.
Instead of checking the schema, this pulls the config down and checks if it's empty. Closes #10984