Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update alert count table to display rules with long names #115920

Merged
merged 3 commits into from
Oct 25, 2021
Merged

Update alert count table to display rules with long names #115920

merged 3 commits into from
Oct 25, 2021

Conversation

machadoum
Copy link
Member

@machadoum machadoum commented Oct 21, 2021 •
edited
Loading

issue: #115538

Summary

Allow rule name with multiple lines on alert count table.

This issue #108914 intentionally removed the tooltip and the component we are using to render the rule name field (DefaultDraggable) doesn't support truncated text. In my opinion, the best solution for this scenario is to display the rule name on multiple lines.

Screenshot 2021-10-21 at 12 45 45

@machadoum machadoum added bug Fixes for quality problems that affect the customer experience v8.0.0 release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed Team:Threat Hunting:Cases Team:Threat Hunting:Explore v7.16.1 labels Oct 21, 2021
@machadoum machadoum self-assigned this Oct 21, 2021
@machadoum machadoum requested a review from a team as a code owner October 21, 2021 10:58
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting-cases (Team:Threat Hunting:Cases)

@machadoum machadoum mentioned this pull request Oct 21, 2021
Closed
@machadoum machadoum added v7.16.0 and removed v7.16.1 labels Oct 21, 2021
@machadoum
Copy link
Member Author

@elasticmachine merge upstream

@machadoum machadoum requested a review from monina-n October 25, 2021 07:46
@machadoum
Copy link
Member Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @machadoum

michaelolo24
michaelolo24 approved these changes Oct 25, 2021
View reviewed changes
Copy link
Contributor

@michaelolo24 michaelolo24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

monina-n
monina-n approved these changes Oct 25, 2021
View reviewed changes
Copy link

@monina-n monina-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good with design

@machadoum machadoum merged commit 1527535 into elastic:master Oct 25, 2021
@kibanamachine kibanamachine mentioned this pull request Oct 25, 2021
Merged
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Oct 25, 2021
@machadoum @kibanamachine
Update alert count table to display rules with long names (elastic#11…
d5ce5f6 
…5920)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Oct 25, 2021
@machadoum @kibanamachine
Update alert count table to display rules with long names (elastic#11…
de5c22e 
…5920)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request Oct 25, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.16
✅ 7.15

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Oct 25, 2021
@kibanamachine @machadoum
Update alert count table to display rules with long names (#115920) (#…
f3f531e 
…116153)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Pablo Machado <pablo.nevesmachado@elastic.co>
kibanamachine added a commit that referenced this pull request Oct 25, 2021
@kibanamachine @machadoum
Update alert count table to display rules with long names (#115920) (#…
009dc1d 
…116152)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Pablo Machado <pablo.nevesmachado@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelolo24 michaelolo24 michaelolo24 approved these changes

@monina-n monina-n monina-n approved these changes

Assignees

@machadoum machadoum

Labels
auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Explore v7.15.2 v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@machadoum @elasticmachine @kibanamachine @michaelolo24 @monina-n