[Lens] Opening advanced Intervals editor should not throw an error #115801

dej611 · 2021-10-20T15:32:15Z

Summary

Fixes #112225

Provided a fix as suggested in the issue + a couple of unit tests.

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk	Probability	Severity	Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space.	Low	High	Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks.	High	Low	Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled.	Medium	High	Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

This was checked for breaking API changes and was labeled appropriately

kibanamachine · 2021-10-20T18:03:39Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 33d9a9a
Storybooks Preview
Pipeline Steps (look for red circles / failed steps)
Interpreting CI Failures

Failed CI Steps

Jest Unit Tests

Test Failures

Kibana Pipeline / jest / Jest Tests.x-pack/plugins/security/public/management/users/edit_user.EditUserPage changes password of other user when submitting form and closes dialog

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 1 times on tracked branches: https://github.com/elastic/kibana/issues/115473

Stack Trace

Error: thrown: "Exceeded timeout of 5000 ms for a test.
Use jest.setTimeout(newTimeout) to increase the timeout value, if this is a long-running test."
    at /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/security/public/management/users/edit_user/edit_user_page.test.tsx:215:3
    at _dispatchDescribe (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/index.js:67:26)
    at describe (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/index.js:30:5)
    at Object.<anonymous> (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/security/public/management/users/edit_user/edit_user_page.test.tsx:37:1)
    at Runtime._execModule (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runtime/build/index.js:1299:24)
    at Runtime._loadModule (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runtime/build/index.js:898:12)
    at Runtime.requireModule (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runtime/build/index.js:746:10)
    at jestAdapter (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:106:13)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at runTestInternal (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/runTest.js:380:16)
    at runTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/runTest.js:472:34)
    at Object.worker (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/testWorker.js:133:12)

Kibana Pipeline / jest / Jest Tests.x-pack/plugins/security/public/management/users/edit_user.EditUserPage validates change password form

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 1 times on tracked branches: https://github.com/elastic/kibana/issues/115474

Stack Trace

Error: thrown: "Exceeded timeout of 5000 ms for a test.
Use jest.setTimeout(newTimeout) to increase the timeout value, if this is a long-running test."
    at /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/security/public/management/users/edit_user/edit_user_page.test.tsx:328:3
    at _dispatchDescribe (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/index.js:67:26)
    at describe (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/index.js:30:5)
    at Object.<anonymous> (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/security/public/management/users/edit_user/edit_user_page.test.tsx:37:1)
    at Runtime._execModule (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runtime/build/index.js:1299:24)
    at Runtime._loadModule (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runtime/build/index.js:898:12)
    at Runtime.requireModule (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runtime/build/index.js:746:10)
    at jestAdapter (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:106:13)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at runTestInternal (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/runTest.js:380:16)
    at runTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/runTest.js:472:34)
    at Object.worker (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/testWorker.js:133:12)

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`lens`	1.0MB	1.0MB	+14.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

dej611 · 2021-10-21T08:33:04Z

@elasticmachine merge upstream

elasticmachine · 2021-10-21T13:54:19Z

Pinging @elastic/kibana-vis-editors (Team:VisEditors)

mbondyra · 2021-10-22T06:16:31Z

@elasticmachine merge upstream

mbondyra · 2021-10-22T06:45:09Z

Tested on FF, the error is gone 🆗

dej611 · 2021-10-25T09:11:33Z

@elasticmachine merge upstream

kibanamachine · 2021-10-25T11:18:26Z

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`lens`	1.0MB	1.0MB	+14.0B

History

💛 Build #1180 was flaky 3819c39
💛 Build #816 was flaky e7bfc08

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…lastic#115801) * 🐛 Fix issue with the first rendering * ✅ Add tests for valid and broken scenario Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

kibanamachine · 2021-10-25T12:29:25Z

💚 Backport successful

Status	Branch	Result
✅	7.16

This backport PR will be merged automatically after passing CI.

…115801) (#116121) * 🐛 Fix issue with the first rendering * ✅ Add tests for valid and broken scenario Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>

dej611 added 2 commits October 20, 2021 17:29

🐛 Fix issue with the first rendering

38221b3

✅ Add tests for valid and broken scenario

33d9a9a

dej611 added Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Lens auto-backport Deprecated - use backport:version if exact versions are needed v7.16.0 labels Oct 20, 2021

Merge branch 'master' into fix/112225

e7bfc08

dej611 marked this pull request as ready for review October 21, 2021 13:54

dej611 requested a review from a team as a code owner October 21, 2021 13:54

Merge branch 'master' into fix/112225

3819c39

mbondyra approved these changes Oct 22, 2021

View reviewed changes

Merge branch 'master' into fix/112225

31bc191

dej611 merged commit 5d73e8c into elastic:master Oct 25, 2021

kibanamachine mentioned this pull request Oct 25, 2021

[7.16] [Lens] Opening advanced Intervals editor should not throw an error (#115801) #116121

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Lens] Opening advanced Intervals editor should not throw an error #115801

[Lens] Opening advanced Intervals editor should not throw an error #115801

dej611 commented Oct 20, 2021

kibanamachine commented Oct 20, 2021 •

edited

Loading

Standard Out

Stack Trace

Standard Out

Stack Trace

dej611 commented Oct 21, 2021

elasticmachine commented Oct 21, 2021

mbondyra commented Oct 22, 2021

mbondyra commented Oct 22, 2021

dej611 commented Oct 25, 2021

kibanamachine commented Oct 25, 2021

kibanamachine commented Oct 25, 2021

[Lens] Opening advanced Intervals editor should not throw an error #115801

[Lens] Opening advanced Intervals editor should not throw an error #115801

Conversation

dej611 commented Oct 20, 2021

Summary

Checklist

Risk Matrix

For maintainers

kibanamachine commented Oct 20, 2021 • edited Loading

💔 Build Failed

Failed CI Steps

Test Failures

Standard Out

Stack Trace

Standard Out

Stack Trace

Metrics [docs]

Async chunks

dej611 commented Oct 21, 2021

elasticmachine commented Oct 21, 2021

mbondyra commented Oct 22, 2021

mbondyra commented Oct 22, 2021

dej611 commented Oct 25, 2021

kibanamachine commented Oct 25, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

History

kibanamachine commented Oct 25, 2021

💚 Backport successful

kibanamachine commented Oct 20, 2021 •

edited

Loading