[Maps] fix flaky getTile test #114689
Merged
[Maps] fix flaky getTile test #114689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/kibana-gis (Team:Geo) |
thomasneirynck
approved these changes
Oct 12, 2021
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 12, 2021
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
2 tasks
kibanamachine
added a commit
that referenced
this pull request
Oct 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #114417
#114509 updated the test to ensure the correct feature is used for assert statement. The problem is that there is another place where inconsistent document order returned from _search is causing assertion problems. metafeature.properties.fieldMeta is stringified JSON and this assertion needs to be updated to handle inconsistent ordering of response.