Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ignore_unmapped to geo filters to prevent exceptions #11461

Merged

Conversation

lukasolson
Copy link
Member

This PR adds an additional parameter, ignore_unmapped to geo_bounding_box filters that are created when you create a map visualization and then select bounds to filter by. This has the effect of ignoring when the index pattern doesn't have a matching geo_point field to filter, which was causing issues on dashboards when one index pattern had a geo_point field while others didn't.

Fixes #9387.

@lukasolson lukasolson self-assigned this Apr 26, 2017
@thomasneirynck
Copy link
Contributor

this needs to be rebased for ci to succeed

@lukasolson lukasolson requested a review from Bargs April 28, 2017 21:02
Copy link
Contributor

@Bargs Bargs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending tests passing, LGTM

@lukasolson
Copy link
Member Author

lukasolson commented May 1, 2017

Backported to 5.x (5.5.0) in 732ec35.
Backported to 5.4 (5.4.1) in 72443cd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants