[Lens] Formula: better messages for unsupported field types

[dej611]

Summary

Fixes #111285

Improve last_value error validation and additional formula validation for unsupported data types: note that this means that there are 2 distinct error types now (just extended a case for an existing one tbh).

Checklist

Delete any items that are not applicable to this PR.

• Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
• Documentation was added for features that require explanation or tutorials
• Unit or functional tests were updated or added to match the most common scenarios
• Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
• Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
• If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
• This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
• This was checked for cross-browser compatibility

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk	Probability	Severity	Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space.	Low	High	Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks.	High	Low	Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled.	Medium	High	Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

• This was checked for breaking API changes and was labeled appropriately

[dej611]

@elasticmachine merge upstream

[elasticmachine]

Pinging @elastic/kibana-vis-editors (Team:VisEditors)

[mbondyra]

@elasticmachine merge upstream

[mbondyra]

The code looks good, but there's one more case that you maybe wanna tackle here? :D

1. Create a datatable visualization on ecommerce index pattern
2. Add a metric of last_value on product.price with a timerange of 90 days:

The problem is that this error persists until you correct your syntax and get a correct outcome (so doesn't update to 'incorrect syntax error' when modifying the syntax)

3. When switching to last_value(category.keyword) the previous error persists till you close the flyout.

[dej611]

I'll try to give a look to this, but it is really a different type of error, as it is something at runtime rather than configuration time. I'm 100% with you that the error message should be improved on that side, so I'll check how hard is to fix it here or rather deserves its own issue to track.

[dej611]

I've attempted to fix the raised problem above, but that required to make some strong assumptions: there' no, in fact, a way to know from the configuration side if a valid expression produced an error or just didn't find any data.
As for now a new condition to update the state has been added so that, if a previous valid formula was in place but the resulting table had no data, the error state gets now propagated as well.

While the provided fix works fine for a scenario where the expression evaluation led to an error, it also kicks in when the current visualization has no data for any other reason (i.e. small time range?).
If data, even when none is present, has priority I can easily revert the last change. What do you think @mbondyra ?

[mbondyra]

I think it's the best we can do atm. I'll retest and come back to you.

[dej611]

@elasticmachine merge upstream

[dej611]

@elasticmachine merge upstream

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: f0b0a76
• Storybooks Preview

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
lens	1.0MB	1.0MB	+884.0B

History

• 💚 Build #161916 succeeded f486ba5
• 💚 Build #161315 succeeded fd27dde
• 💛 Build #160864 was flaky 7209521
• 💚 Build #159842 succeeded 18d0b9d
• 💔 Build #159609 failed a562496

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[mbondyra]

LGTM, tested and works as expected!

[kibanamachine]

💚 Backport successful

Status	Branch	Result
✅	7.16

This backport PR will be merged automatically after passing CI.